Hi Oliver!!
I now realize that the checkstyle plugin is not smart as we expect :)
I guess you launched `mvn checkstyle:checkstyle`, if you do a
`svn up && mvn clean site && open target/site/checkstyle.html`
you can see totally different result!!!
Please let me know, many thanks in advance!
All the best,
Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Sun, Oct 23, 2011 at 8:06 PM, Oliver Heger
<oliver.he...@oliver-heger.de> wrote:
> Am 23.10.2011 18:37, schrieb Simone Tripodi:
>>
>> Nice hint, thanks Phil!!!
>> all the best,
>> Simo
>
> It's really strange. I locally changed the digester pom to use version 2.7
> of checkstyle, but again I see the same errors. I uploaded checkstyle.html
> to [1] so you can have a look at the output.
>
> Are the warnings really meaningful and do they correspond to your checkstyle
> configuration?
>
> Oliver
>
> [1] http://people.apache.org/~oheger/checkstyle.html
>
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>>
>>
>> On Sun, Oct 23, 2011 at 6:10 PM, Phil Steitz<phil.ste...@gmail.com>
>> wrote:
>>>
>>> On 10/22/11 8:02 AM, Oliver Heger wrote:
>>>>
>>>> Am 21.10.2011 23:19, schrieb Simone Tripodi:
>>>>>
>>>>> Forgot to mention about checkstyle: no idea. If you built the
>>>>> Digester
>>>>> using the provided pom, there shouldn't be ambiguity... any hint?
>>>>
>>>> Being no maven guru, I haven't got a clue either. I also would
>>>> expect that the pom contains sufficient information to have
>>>> reproducible build results. I ran a mvn help:effective-pom, and
>>>> here is the part I got for the configuration of the checkstyle
>>>> plug-in:
>>>>
>>>> <plugin>
>>>> <artifactId>maven-checkstyle-plugin</artifactId>
>>>> <version>2.6</version>
>>>> <configuration>
>>>> <configLocation>config/maven_checks.xml</configLocation>
>>>> <headerLocation>config/maven-header.txt</headerLocation>
>>>>
>>>>
>>>> <suppressionsLocation>D:\data\projects\OpenSource\digester\commons-digester3-3.1-src/checkstyle-suppressions.xml</suppressionsLocation>
>>>>
>>>>
>>>>
>>>> <suppressionsFileExpression>D:\data\projects\OpenSource\digester\commons-digester3-3.1-src/checkstyle-suppressions.xml</suppressionsFileExpression>
>>>>
>>>> </configuration>
>>>> </plugin>
>>>>
>>>> Do you get a similar result?
>>>
>>> Looks like the plugin version is 2.6. Could be the failure on
>>> Windows is due to [1] which is fixed in 2.7. Try changing the
>>> plugin version to 2.7 and see if that fixes it.
>>>
>>> Phil
>>> [1] http://jira.codehaus.org/browse/MCHECKSTYLE-149
>>>>
>>>> Oliver
>>>>
>>>>> TIA!!!
>>>>> Simo
>>>>>
>>>>> http://people.apache.org/~simonetripodi/
>>>>> http://simonetripodi.livejournal.com/
>>>>> http://twitter.com/simonetripodi
>>>>> http://www.99soft.org/
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Oct 21, 2011 at 11:14 PM, Simone Tripodi
>>>>> <simonetrip...@apache.org> wrote:
>>>>>>
>>>>>> Hi Oliver,
>>>>>> thanks for the deep review!!
>>>>>>
>>>>>> I think that under a legal point of view - NOTICE file is
>>>>>> included in
>>>>>> the artifact - it would be better give another RC and take
>>>>>> advantage
>>>>>> to fix also PMD violations.
>>>>>>
>>>>>> Let's wait anyway for the end of the vote and see how thing go,
>>>>>> in the
>>>>>> meanwhile I fix what you noticed.
>>>>>>
>>>>>> Thanks a lot, alles gute!
>>>>>> Simo
>>>>>>
>>>>>> http://people.apache.org/~simonetripodi/
>>>>>> http://simonetripodi.livejournal.com/
>>>>>> http://twitter.com/simonetripodi
>>>>>> http://www.99soft.org/
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Fri, Oct 21, 2011 at 10:08 PM, Oliver Heger
>>>>>> <oliver.he...@oliver-heger.de> wrote:
>>>>>>>
>>>>>>> Build works fine with Java 1.5 on Windows 7. Artifacts look good.
>>>>>>>
>>>>>>> I found the following problems:
>>>>>>> - The Copyright in NOTICE.txt says still 2010.
>>>>>>> - The release notes claim to be for version 3.0 in the header.
>>>>>>> - There are some PMD errors which could be addressed (not
>>>>>>> blocking).
>>>>>>> - A bit strange: When I build the site locally I get 75
>>>>>>> Checkstyle errors.
>>>>>>> Maybe this depends on the version of the checkstyle plug-in?
>>>>>>>
>>>>>>> Oliver
>>>>>>>
>>>>>>> Am 19.10.2011 23:38, schrieb Simone Tripodi:
>>>>>>>>
>>>>>>>> Hi all guys,
>>>>>>>> I'm writing to call for a vote to release apache
>>>>>>>> commons-digester-3.1
>>>>>>>> based on RC1.
>>>>>>>>
>>>>>>>> This is the 3.0 release with the new async feature - not very
>>>>>>>> much but
>>>>>>>> enough to justify a new release.
>>>>>>>> Please take in consideration that broken 3.1 links will be
>>>>>>>> fixed once
>>>>>>>> the site will be deployed.
>>>>>>>>
>>>>>>>> The vote will stay open for 72 hours anc closes on Saturday
>>>>>>>> 22th, at
>>>>>>>> 9:40pm CET.
>>>>>>>>
>>>>>>>> Many thanks in advance for reviewing, have a nice day!
>>>>>>>> All the best,
>>>>>>>> Simo
>>>>>>>>
>>>>>>>> Release notes:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> http://people.apache.org/builds/commons/digester/3.1/RC1/RELEASE-NOTES.txt
>>>>>>>>
>>>>>>>> Tag:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC1/
>>>>>>>>
>>>>>>>>
>>>>>>>> Site:
>>>>>>>>
>>>>>>>> http://people.apache.org/builds/commons/digester/3.1/RC1/site/
>>>>>>>>
>>>>>>>> Binaries:
>>>>>>>>
>>>>>>>>
>>>>>>>> http://people.apache.org/builds/commons/digester/3.1/RC1/binaries/
>>>>>>>>
>>>>>>>>
>>>>>>>> Maven Artifacts (staged on Nexus)
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> https://repository.apache.org/content/repositories/orgapachecommons-080/org/apache/commons/commons-digester3/
>>>>>>>>
>>>>>>>>
>>>>>>>> [ ] +1 release it
>>>>>>>> [ ] +0 go ahead I don't care
>>>>>>>> [ ] -1 no, do not release it because... (please explain why)
>>>>>>>>
>>>>>>>> http://people.apache.org/~simonetripodi/
>>>>>>>> http://simonetripodi.livejournal.com/
>>>>>>>> http://twitter.com/simonetripodi
>>>>>>>> http://www.99soft.org/
>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>>
>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>>
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
