Hallo Oliver, All's well that ends well :) Nice to see you finally got the expected results! Thanks for reviewing, I'll push a new RC in a short while! All the best, alles gute! Simo
http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Mon, Oct 24, 2011 at 9:50 PM, Oliver Heger <oliver.he...@oliver-heger.de> wrote: > Am 23.10.2011 22:43, schrieb Phil Steitz: >> >> On 10/23/11 12:42 PM, Oliver Heger wrote: >>> >>> Am 23.10.2011 20:16, schrieb Simone Tripodi: >>>> >>>> Hi Oliver!! >>>> I now realize that the checkstyle plugin is not smart as we >>>> expect :) >>>> >>>> I guess you launched `mvn checkstyle:checkstyle`, if you do a >>>> >>>> `svn up&& mvn clean site&& open target/site/checkstyle.html` >>>> >>>> you can see totally different result!!! >>>> Please let me know, many thanks in advance! >>>> All the best, >>>> Simo >>> >>> Hm, actually I did a mvn clean site:site. >> >> Beats me. Looks like you are still just not picking up the >> suppressions file. Try running mvn with the -d or whatever the >> debug thingy is and see what file it is trying to pick up. Normally >> the / will get correctly changed to a \ for Windows. I thought that >> it might be the suppressionsFileExpression that needed to be >> changed, since what is in the [digester] pom is different from the >> example in the docs; but it doesn't seem to matter what you put >> there, as long as it is non-empty. The docs say nothing about what >> that property should be set to and the code seems to ignore it, >> other than checking that its not null. > > I did a fresh checkout from digester3 trunk and ran mvn site:site -X. As can > be seen below, the correct suppression files are detected and used - and > indeed, the problem disappeared. No warnings any more. > > No idea what caused the problem, maybe some old stuff hanging around. One of > those mysteries that occur from time to time in this business :-( > > Oliver > > [DEBUG] Configuring mojo > 'org.apache.maven.plugins:maven-checkstyle-plugin:2.7:checkstyle' --> > [DEBUG] (f) cacheFile = > D:\data\projects\OpenSource\digester\checkout\commons-digester3\target/checkstyle-cachefile > [DEBUG] (f) configLocation = config/maven_checks.xml > [DEBUG] (f) consoleOutput = false > [DEBUG] (f) enableFilesSummary = true > [DEBUG] (f) enableRSS = true > [DEBUG] (f) enableRulesSummary = true > [DEBUG] (f) enableSeveritySummary = true > [DEBUG] (f) encoding = iso-8859-1 > [DEBUG] (f) failsOnError = false > [DEBUG] (f) format = sun > [DEBUG] (f) headerFile = > D:\data\projects\OpenSource\digester\checkout\commons-digester3\LICENSE.txt > [DEBUG] (f) headerLocation = config/maven-header.txt > [DEBUG] (f) includes = **/*.java > [DEBUG] (f) linkXRef = true > [DEBUG] (f) outputDirectory = > D:\data\projects\OpenSource\digester\checkout\commons-digester3\target\site > [DEBUG] (f) outputFile = > D:\data\projects\OpenSource\digester\checkout\commons-digester3\target\checkstyle-result.xml > [DEBUG] (f) outputFileFormat = xml > [DEBUG] (f) project = MavenProject: > org.apache.commons:commons-digester3:3.1-SNAPSHOT @ > D:\data\projects\OpenSource\digester\checkout\commons-digester3\pom.xml > [DEBUG] (f) skip = false > [DEBUG] (f) sourceDirectory = > D:\data\projects\OpenSource\digester\checkout\commons-digester3\src\main\java > [DEBUG] (f) suppressionsFileExpression = > D:\data\projects\OpenSource\digester\checkout\commons-digester3/checkstyle-suppressions.xml > [DEBUG] (f) suppressionsLocation = > D:\data\projects\OpenSource\digester\checkout\commons-digester3/checkstyle-suppressions.xml > [DEBUG] (f) testSourceDirectory = > D:\data\projects\OpenSource\digester\checkout\commons-digester3\src\test\java > [DEBUG] (f) xrefLocation = > D:\data\projects\OpenSource\digester\checkout\commons-digester3\target\site\xref > > >> >> Another thing that I noticed running the build is >> [WARNING] >> >> /Users/philsteitz/digester/trunk/src/main/java/org/apache/commons/digester3/CallMethodRule.java:85: >> warning - Tag @link: reference not found: MethodUtils#invokeMethod >> [WARNING] >> >> /Users/philsteitz/digester/trunk/src/main/java/org/apache/commons/digester3/CallMethodRule.java:85: >> warning - Tag @link: reference not found: MethodUtils#invokeExactMethod >> >> These are because the BeanUtils MethodUtils class is not imported >> fully any more. Either you need to just import the class or fully >> qualify the names in the links. Are we sure that the class javadoc >> here and elsewhere is correct for 3.0? >> >> Phil >>> >>> Oliver >>> >>>> >>>> http://people.apache.org/~simonetripodi/ >>>> http://simonetripodi.livejournal.com/ >>>> http://twitter.com/simonetripodi >>>> http://www.99soft.org/ >>>> >>>> >>>> >>>> On Sun, Oct 23, 2011 at 8:06 PM, Oliver Heger >>>> <oliver.he...@oliver-heger.de> wrote: >>>>> >>>>> Am 23.10.2011 18:37, schrieb Simone Tripodi: >>>>>> >>>>>> Nice hint, thanks Phil!!! >>>>>> all the best, >>>>>> Simo >>>>> >>>>> It's really strange. I locally changed the digester pom to use >>>>> version 2.7 >>>>> of checkstyle, but again I see the same errors. I uploaded >>>>> checkstyle.html >>>>> to [1] so you can have a look at the output. >>>>> >>>>> Are the warnings really meaningful and do they correspond to >>>>> your checkstyle >>>>> configuration? >>>>> >>>>> Oliver >>>>> >>>>> [1] http://people.apache.org/~oheger/checkstyle.html >>>>> >>>>>> >>>>>> http://people.apache.org/~simonetripodi/ >>>>>> http://simonetripodi.livejournal.com/ >>>>>> http://twitter.com/simonetripodi >>>>>> http://www.99soft.org/ >>>>>> >>>>>> >>>>>> >>>>>> On Sun, Oct 23, 2011 at 6:10 PM, Phil >>>>>> Steitz<phil.ste...@gmail.com> >>>>>> wrote: >>>>>>> >>>>>>> On 10/22/11 8:02 AM, Oliver Heger wrote: >>>>>>>> >>>>>>>> Am 21.10.2011 23:19, schrieb Simone Tripodi: >>>>>>>>> >>>>>>>>> Forgot to mention about checkstyle: no idea. If you built the >>>>>>>>> Digester >>>>>>>>> using the provided pom, there shouldn't be ambiguity... any >>>>>>>>> hint? >>>>>>>> >>>>>>>> Being no maven guru, I haven't got a clue either. I also would >>>>>>>> expect that the pom contains sufficient information to have >>>>>>>> reproducible build results. I ran a mvn help:effective-pom, and >>>>>>>> here is the part I got for the configuration of the checkstyle >>>>>>>> plug-in: >>>>>>>> >>>>>>>> <plugin> >>>>>>>> <artifactId>maven-checkstyle-plugin</artifactId> >>>>>>>> <version>2.6</version> >>>>>>>> <configuration> >>>>>>>> >>>>>>>> <configLocation>config/maven_checks.xml</configLocation> >>>>>>>> >>>>>>>> <headerLocation>config/maven-header.txt</headerLocation> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> <suppressionsLocation>D:\data\projects\OpenSource\digester\commons-digester3-3.1-src/checkstyle-suppressions.xml</suppressionsLocation> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> <suppressionsFileExpression>D:\data\projects\OpenSource\digester\commons-digester3-3.1-src/checkstyle-suppressions.xml</suppressionsFileExpression> >>>>>>>> >>>>>>>> >>>>>>>> </configuration> >>>>>>>> </plugin> >>>>>>>> >>>>>>>> Do you get a similar result? >>>>>>> >>>>>>> Looks like the plugin version is 2.6. Could be the failure on >>>>>>> Windows is due to [1] which is fixed in 2.7. Try changing the >>>>>>> plugin version to 2.7 and see if that fixes it. >>>>>>> >>>>>>> Phil >>>>>>> [1] http://jira.codehaus.org/browse/MCHECKSTYLE-149 >>>>>>>> >>>>>>>> Oliver >>>>>>>> >>>>>>>>> TIA!!! >>>>>>>>> Simo >>>>>>>>> >>>>>>>>> http://people.apache.org/~simonetripodi/ >>>>>>>>> http://simonetripodi.livejournal.com/ >>>>>>>>> http://twitter.com/simonetripodi >>>>>>>>> http://www.99soft.org/ >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Fri, Oct 21, 2011 at 11:14 PM, Simone Tripodi >>>>>>>>> <simonetrip...@apache.org> wrote: >>>>>>>>>> >>>>>>>>>> Hi Oliver, >>>>>>>>>> thanks for the deep review!! >>>>>>>>>> >>>>>>>>>> I think that under a legal point of view - NOTICE file is >>>>>>>>>> included in >>>>>>>>>> the artifact - it would be better give another RC and take >>>>>>>>>> advantage >>>>>>>>>> to fix also PMD violations. >>>>>>>>>> >>>>>>>>>> Let's wait anyway for the end of the vote and see how thing >>>>>>>>>> go, >>>>>>>>>> in the >>>>>>>>>> meanwhile I fix what you noticed. >>>>>>>>>> >>>>>>>>>> Thanks a lot, alles gute! >>>>>>>>>> Simo >>>>>>>>>> >>>>>>>>>> http://people.apache.org/~simonetripodi/ >>>>>>>>>> http://simonetripodi.livejournal.com/ >>>>>>>>>> http://twitter.com/simonetripodi >>>>>>>>>> http://www.99soft.org/ >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Fri, Oct 21, 2011 at 10:08 PM, Oliver Heger >>>>>>>>>> <oliver.he...@oliver-heger.de> wrote: >>>>>>>>>>> >>>>>>>>>>> Build works fine with Java 1.5 on Windows 7. Artifacts >>>>>>>>>>> look good. >>>>>>>>>>> >>>>>>>>>>> I found the following problems: >>>>>>>>>>> - The Copyright in NOTICE.txt says still 2010. >>>>>>>>>>> - The release notes claim to be for version 3.0 in the >>>>>>>>>>> header. >>>>>>>>>>> - There are some PMD errors which could be addressed (not >>>>>>>>>>> blocking). >>>>>>>>>>> - A bit strange: When I build the site locally I get 75 >>>>>>>>>>> Checkstyle errors. >>>>>>>>>>> Maybe this depends on the version of the checkstyle plug-in? >>>>>>>>>>> >>>>>>>>>>> Oliver >>>>>>>>>>> >>>>>>>>>>> Am 19.10.2011 23:38, schrieb Simone Tripodi: >>>>>>>>>>>> >>>>>>>>>>>> Hi all guys, >>>>>>>>>>>> I'm writing to call for a vote to release apache >>>>>>>>>>>> commons-digester-3.1 >>>>>>>>>>>> based on RC1. >>>>>>>>>>>> >>>>>>>>>>>> This is the 3.0 release with the new async feature - not >>>>>>>>>>>> very >>>>>>>>>>>> much but >>>>>>>>>>>> enough to justify a new release. >>>>>>>>>>>> Please take in consideration that broken 3.1 links will be >>>>>>>>>>>> fixed once >>>>>>>>>>>> the site will be deployed. >>>>>>>>>>>> >>>>>>>>>>>> The vote will stay open for 72 hours anc closes on Saturday >>>>>>>>>>>> 22th, at >>>>>>>>>>>> 9:40pm CET. >>>>>>>>>>>> >>>>>>>>>>>> Many thanks in advance for reviewing, have a nice day! >>>>>>>>>>>> All the best, >>>>>>>>>>>> Simo >>>>>>>>>>>> >>>>>>>>>>>> Release notes: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> http://people.apache.org/builds/commons/digester/3.1/RC1/RELEASE-NOTES.txt >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Tag: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC1/ >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Site: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> http://people.apache.org/builds/commons/digester/3.1/RC1/site/ >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Binaries: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> http://people.apache.org/builds/commons/digester/3.1/RC1/binaries/ >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Maven Artifacts (staged on Nexus) >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> https://repository.apache.org/content/repositories/orgapachecommons-080/org/apache/commons/commons-digester3/ >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> [ ] +1 release it >>>>>>>>>>>> [ ] +0 go ahead I don't care >>>>>>>>>>>> [ ] -1 no, do not release it because... (please explain why) >>>>>>>>>>>> >>>>>>>>>>>> http://people.apache.org/~simonetripodi/ >>>>>>>>>>>> http://simonetripodi.livejournal.com/ >>>>>>>>>>>> http://twitter.com/simonetripodi >>>>>>>>>>>> http://www.99soft.org/ >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> --------------------------------------------------------------------- >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>>>>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> --------------------------------------------------------------------- >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>>>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> --------------------------------------------------------------------- >>>>>>>>> >>>>>>>>> >>>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> --------------------------------------------------------------------- >>>>>>>> >>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> --------------------------------------------------------------------- >>>>>>> >>>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>>>> >>>>>>> >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> >>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>>> >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> >>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>> >>>>> >>>> >>>> --------------------------------------------------------------------- >>>> >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
