Also, the checkstyle reports do not like the headers: Line does not match expected header line of ' * Unless required by applicable law or agreed to in writing, software'.
There are many checkstyle issues reported but I am not sure that is any worse thank before. PMD has many: Avoid modifiers which are implied by the context Which should be easy to fix, it just takes time. Gary On Fri, Sep 26, 2014 at 5:27 PM, Gary Gregory <[email protected]> wrote: > -1 (sorry). With the source zip, I ran 'mvn clean site' and got: > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 03:33 min > [INFO] Finished at: 2014-09-26T17:21:37-04:00 > [INFO] Final Memory: 65M/686M > [INFO] > ------------------------------------------------------------------------ > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.3:site (default-site) on > project bcel: Error during page generation: Error rendering Maven report: > Failed during checkstyle execution: Unable to process header loca > tion: C:\temp\rc\bcel-6.0-src\LICENSE-header.txt: Could not find resource > 'C:\temp\rc\bcel-6.0-src\LICENSE-header.txt'. -> [Help 1] > [ERROR] > > So you've got a missing file in the source zip. It sounds like the source > assembly needs to be adjusted. > > Also Cobertura blows up (i'm not sure Jacoco would fare better but it > might be worth a try): > > Tests in error: > AnnotationGenTestCase.testConstructMutableAnnotation:68 > ExceptionInInitializer > AnnotationGenTestCase.testVisibleInvisibleAnnotationGen:93 > NoClassDefFound Cou... > ElementValueGenTestCase.testCreateClassElementValue:205 NoClassDefFound > Could ... > ElementValueGenTestCase.testCreateEnumElementValue:181 NoClassDefFound > Could n... > > FieldAnnotationsTestCase.testFieldAnnotationModification:82->AbstractTestCase.createFruitAnnotationEntry:176 > » NoClassDefFound > > GeneratingAnnotatedClassesTestCase.testGenerateMethodLevelAnnotations1:143->buildClassContentsWithAnnotatedMethods:436->createMethodGen:640 > NoClassDefFound > > GeneratingAnnotatedClassesTestCase.testGenerateMethodLevelAnnotations2:182->buildClassContentsWithAnnotatedMethods:436->createMethodGen:640 > NoClassDefFound > > GeneratingAnnotatedClassesTestCase.testGenerateClassLevelAnnotations:100->createSimpleVisibleAnnotation:655 > NoClassDefFound > > GeneratingAnnotatedClassesTestCase.testModifyingClasses1:386->createFruitAnnotation:668 > NoClassDefFound > > GeneratingAnnotatedClassesTestCase.testModifyingClasses2:403->createCombinedAnnotation:677->createSimpleVisibleAnnotation:655 > NoClassDefFound > InstructionFinderTestCase.testSearchAll:38 » NoClassDefFound Could not > initial... > VerifierTestCase.testDefaultMethodValidation:35 » NoClassDefFound Could > not in... > > Tests run: 74, Failures: 0, Errors: 12, Skipped: 0 > > I used Java 7 and 8 on Windows (all 64-bit): > > Apache Maven 3.2.3 (33f8c3e1027c3ddde99d3cdebad2656a31e8fdf4; > 2014-08-11T16:58:10-04:00) > Maven home: C:\Java\apache-maven-3.2.3 > Java version: 1.8.0_20, vendor: Oracle Corporation > Java home: C:\Program Files\Java\jdk1.8.0_20\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos" > > Apache Maven 3.2.3 (33f8c3e1027c3ddde99d3cdebad2656a31e8fdf4; > 2014-08-11T16:58:10-04:00) > Maven home: C:\Java\apache-maven-3.2.3 > Java version: 1.7.0_67, vendor: Oracle Corporation > Java home: C:\Program Files\Java\jdk1.7.0_67\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" > > Gary > > On Fri, Sep 26, 2014 at 5:12 PM, Emmanuel Bourg <[email protected]> wrote: > >> Hi all, >> >> The second release candidate of BCEL is ready to pass under your scrutiny. >> >> Tag: >> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC2/ >> (r1627879 >> <http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC2/(r1627879> >> ) >> >> Release notes: >> http://people.apache.org/~ebourg/bcel/RELEASE-NOTES.txt >> >> Distribution files: >> http://people.apache.org/~ebourg/bcel/ >> >> Checksums (sha1): >> a93e9b33dce3473da2462a709c3e904a5f569526 bcel-6.0-bin.tar.gz >> 0ff280375294d9b67eba45483b94918edd753a79 bcel-6.0-bin.zip >> b0a9c5054e366141fccc2bec55983bc7796b2017 bcel-6.0-src.tar.gz >> bade1e07121a9a6283d87b0ad94888a99043d333 bcel-6.0-src.zip >> >> Site: >> http://people.apache.org/~ebourg/bcel/site/ >> >> Javadoc: >> http://people.apache.org/~ebourg/bcel/site/apidocs/ >> >> Maven artifacts: >> >> https://repository.apache.org/content/repositories/orgapachecommons-1046/org/apache/bcel/bcel/6.0/ >> >> >> Please review the release candidate and vote. >> This vote will close no sooner that 72 hours from now. >> >> [ ] +1 Release these artifacts >> [ ] +0 OK, but... >> [ ] -0 OK, but really should fix... >> [ ] -1 I oppose this release because... >> >> Thank you for your reviews, >> >> Emmanuel Bourg >> >> >> > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
