> On Sep 7, 2020, at 6:15 AM, Mark Thomas <ma...@apache.org> wrote:
>
> On 04/09/2020 12:30, Rob Tompkins wrote:
>> +1 binding.
>
> Thanks for testing and voting.
>
>> Builds on java 7 and java 11 works with ‘mvn clean test’
>>
>> Build on java 8 works with ‘mvn clean test install site’
>>
>> % mvn -version
>> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
>> Maven home: /usr/local/Cellar/maven/3.6.3_1/libexec
>> Java version: 1.8.0_242, vendor: Amazon.com Inc., runtime:
>> /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/jre
>> Default locale: en_US, platform encoding: UTF-8
>> OS name: "mac os x", version: "10.15.6", arch: "x86_64", family: “mac"
>>
>> Few nits in project reports (don’t see japicmp, or jacoco. Don’t know if
>> this matters).
>> RAT good, site good.
>
> Neither of those two are configured.
>
> There is probably benefit in enabling japicmp. While the API hasn't
> changed in years, there have been various clean-ups applied and checking
> those clean-ups haven't changed the API would be good. I tried adding
> japicmp to daemon ready for the next release but my Maven foo wasn't up
> to it even when copying the config from DBCP. I must have missed something.
>
> jacoco isn't configured because there aren't any unit tests for Daemon.
> The bulk of the project is interfaces. There isn't much that can be
> usefully tested.
>
>> Note, release validation is difficult as Sebb and Gary suggest, but that
>> does not make it an invalid RC by any means.
>
> Difficult how? I've yet to see an explanation for why it is necessary
> (or even helpful) to include artefact hashes in the vote mail.
> Validating the svn revision for the dist repo is a lot easier (and
> quicker) than comparing the hashes of each file to a hash provided in
> the vote email. Isn't it?
>
> Generating the list the artefacts and their hashes for the vote mail
> takes time I would rather be spending fixing other issues.
I agree and understand all your points here. I was merely trying to offer the
opposing perspective of the other folks.
Cheers,
-Rob
>
> Mark
>
>
>>
>> Cheers,
>> -Rob
>>
>>>> On Sep 1, 2020, at 2:25 PM, Mark Thomas <ma...@apache.org> wrote:
>>>
>>> Apologies for the slight delay between the tag and the vote. There was
>>> an issue with the code signing service we use to sign the Windows binaries.
>>>
>>> It has been almost a year since the last Commons Daemon release. Notable
>>> changes since 1.2.2 include:
>>> - Improved debug logging for error conditions
>>> - Added support for Java's Native Memory Tracing
>>> - Added a procrun command to output the current configuration
>>>
>>> The full set of changes is in the changelog
>>>
>>> 1.2.3 RC1 can be obtained from (r41271)
>>> https://dist.apache.org/repos/dist/dev/commons/daemon/
>>>
>>> The git tag is:
>>> Tag: COMMONS_DAEMON_1_2_3_RC1
>>> URL:
>>> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=f42d76aaa22df5f6bfa2f745ba2985bc47fe28d1
>>> Hash: f42d76aaa22df5f6bfa2f745ba2985bc47fe28d1
>>>
>>> The Maven Staging repo is:
>>> https://repository.apache.org/content/repositories/orgapachecommons-1525/
>>>
>>> The Windows binaries have been signed by the DigiCert (formerly
>>> Symantec) code signing service.
>>>
>>> Files signed with my preferred key:
>>> http://people.apache.org/~markt/
>>> KEYS file is standard Apache Commons keys file:
>>> http://www.apache.org/dist/commons/KEYS
>>>
>>>
>>> [ ] Approved - go ahead and release Commons Daemon 1.2.3 RC1 as 1.2.3
>>> [ ] Broken - do not release because...
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
