+1
Tested using:
commons-daemon-1.2.3-src.zip=41bb51826f4c90d00091c258e03275142c64a33d898e65eea901fe00f7d75d13fcae4d783337c77bf5d4b6cda428bc12a092b28260c0c77b706e456ab410e14a
sha512sum says OK.
Apache RAT check OK
Apache CLIRR check OK
TODO: Add Maven command line and report support for Checkstyle,
SpotBugs, and JApiCmp.
Java build OK using 'mvn clean package site' using:
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: 1.8.0_251, vendor: Oracle Corporation, runtime:
C:\Program Files\Java\jdk1.8.0_251\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
Reports generated OK aside from TODO above.
Windows binaries generated OK using:
Microsoft Windows [Version 10.0.16299.2045]
Microsoft (R) Program Maintenance Utility Version 14.26.28806.0
Microsoft (R) C/C++ Optimizing Compiler Version 19.26.28806 for x64
Microsoft (R) Incremental Linker Version 14.26.28806.0
Linux binaries generated OK using the Windows Linux Subsystem:
Linux US-L-GG02 4.4.0-43-Microsoft #1-Microsoft Wed Dec 31 14:42:53
PST 2014 x86_64 x86_64 x86_64 GNU/Linux
openjdk version "1.8.0_252"
OpenJDK Runtime Environment (build 1.8.0_252-8u252-b09-1~18.04-b09)
OpenJDK 64-Bit Server VM (build 25.252-b09, mixed mode)
Note some warnings are generated:
root@US-L-GG02:/mnt/c/test/commons-daemon-1.2.3-src/src/native/unix# make
(cd native; make all)
make[1]: Entering directory
'/mnt/c/test/commons-daemon-1.2.3-src/src/native/unix/native'
gcc -g -O2 -DOS_LINUX -DDSO_DLFCN -DCPU=\"amd64\" -Wall
-Wstrict-prototypes -I/usr/lib/jvm/java-8-openjdk-amd64//include
-I/usr/lib/jvm/java-8-openjdk-amd64//include/linux -c jsvc-unix.c -o
jsvc-unix.o
jsvc-unix.c: In function ‘run_controller’:
jsvc-unix.c:1293:20: warning: assignment from incompatible pointer
type [-Wincompatible-pointer-types]
act.sa_handler = controller;
^
jsvc-unix.c: In function ‘get_pidf’:
jsvc-unix.c:648:5: warning: ignoring return value of ‘lockf’, declared
with attribute warn_unused_result [-Wunused-result]
lockf(fd, F_LOCK, 0);
^~~~~~~~~~~~~~~~~~~~
jsvc-unix.c:650:5: warning: ignoring return value of ‘lockf’, declared
with attribute warn_unused_result [-Wunused-result]
lockf(fd, F_ULOCK, 0);
^~~~~~~~~~~~~~~~~~~~~
jsvc-unix.c: In function ‘wait_child’:
jsvc-unix.c:744:9: warning: ignoring return value of ‘lockf’, declared
with attribute warn_unused_result [-Wunused-result]
lockf(fd, F_LOCK, 0);
^~~~~~~~~~~~~~~~~~~~
jsvc-unix.c:746:9: warning: ignoring return value of ‘lockf’, declared
with attribute warn_unused_result [-Wunused-result]
lockf(fd, F_ULOCK, 0);
^~~~~~~~~~~~~~~~~~~~~
jsvc-unix.c: In function ‘set_output’:
jsvc-unix.c:1046:9: warning: ignoring return value of ‘freopen’,
declared with attribute warn_unused_result [-Wunused-result]
freopen("/dev/null", "r", stdin);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
jsvc-unix.c:1057:9: warning: ignoring return value of ‘freopen’,
declared with attribute warn_unused_result [-Wunused-result]
freopen("/dev/null", "a", stdout);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
jsvc-unix.c:1075:9: warning: ignoring return value of ‘freopen’,
declared with attribute warn_unused_result [-Wunused-result]
freopen("/dev/null", "a", stderr);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
jsvc-unix.c: In function ‘check_pid’:
jsvc-unix.c:574:9: warning: ignoring return value of ‘lockf’, declared
with attribute warn_unused_result [-Wunused-result]
lockf(fd, F_LOCK, 0);
^~~~~~~~~~~~~~~~~~~~
jsvc-unix.c:581:17: warning: ignoring return value of ‘lockf’,
declared with attribute warn_unused_result [-Wunused-result]
lockf(fd, F_ULOCK, 0);
^~~~~~~~~~~~~~~~~~~~~
jsvc-unix.c:591:9: warning: ignoring return value of ‘lockf’, declared
with attribute warn_unused_result [-Wunused-result]
lockf(fd, F_ULOCK, 0);
^~~~~~~~~~~~~~~~~~~~~
jsvc-unix.c: In function ‘remove_pid_file’:
jsvc-unix.c:610:5: warning: ignoring return value of ‘lockf’, declared
with attribute warn_unused_result [-Wunused-result]
lockf(fd, F_LOCK, 0);
^~~~~~~~~~~~~~~~~~~~
jsvc-unix.c:628:5: warning: ignoring return value of ‘lockf’, declared
with attribute warn_unused_result [-Wunused-result]
lockf(fd, F_ULOCK, 0);
^~~~~~~~~~~~~~~~~~~~~
gcc -g -O2 -DOS_LINUX -DDSO_DLFCN -DCPU=\"amd64\" -Wall
-Wstrict-prototypes -I/usr/lib/jvm/java-8-openjdk-amd64//include
-I/usr/lib/jvm/java-8-openjdk-amd64//include/linux -c arguments.c -o
arguments.o
gcc -g -O2 -DOS_LINUX -DDSO_DLFCN -DCPU=\"amd64\" -Wall
-Wstrict-prototypes -I/usr/lib/jvm/java-8-openjdk-amd64//include
-I/usr/lib/jvm/java-8-openjdk-amd64//include/linux -c debug.c -o
debug.o
gcc -g -O2 -DOS_LINUX -DDSO_DLFCN -DCPU=\"amd64\" -Wall
-Wstrict-prototypes -I/usr/lib/jvm/java-8-openjdk-amd64//include
-I/usr/lib/jvm/java-8-openjdk-amd64//include/linux -c dso-dlfcn.c -o
dso-dlfcn.o
gcc -g -O2 -DOS_LINUX -DDSO_DLFCN -DCPU=\"amd64\" -Wall
-Wstrict-prototypes -I/usr/lib/jvm/java-8-openjdk-amd64//include
-I/usr/lib/jvm/java-8-openjdk-amd64//include/linux -c dso-dyld.c -o
dso-dyld.o
gcc -g -O2 -DOS_LINUX -DDSO_DLFCN -DCPU=\"amd64\" -Wall
-Wstrict-prototypes -I/usr/lib/jvm/java-8-openjdk-amd64//include
-I/usr/lib/jvm/java-8-openjdk-amd64//include/linux -c help.c -o help.o
gcc -g -O2 -DOS_LINUX -DDSO_DLFCN -DCPU=\"amd64\" -Wall
-Wstrict-prototypes -I/usr/lib/jvm/java-8-openjdk-amd64//include
-I/usr/lib/jvm/java-8-openjdk-amd64//include/linux -c home.c -o home.o
gcc -g -O2 -DOS_LINUX -DDSO_DLFCN -DCPU=\"amd64\" -Wall
-Wstrict-prototypes -I/usr/lib/jvm/java-8-openjdk-amd64//include
-I/usr/lib/jvm/java-8-openjdk-amd64//include/linux -c java.c -o java.o
gcc -g -O2 -DOS_LINUX -DDSO_DLFCN -DCPU=\"amd64\" -Wall
-Wstrict-prototypes -I/usr/lib/jvm/java-8-openjdk-amd64//include
-I/usr/lib/jvm/java-8-openjdk-amd64//include/linux -c location.c -o
location.o
gcc -g -O2 -DOS_LINUX -DDSO_DLFCN -DCPU=\"amd64\" -Wall
-Wstrict-prototypes -I/usr/lib/jvm/java-8-openjdk-amd64//include
-I/usr/lib/jvm/java-8-openjdk-amd64//include/linux -c replace.c -o
replace.o
gcc -g -O2 -DOS_LINUX -DDSO_DLFCN -DCPU=\"amd64\" -Wall
-Wstrict-prototypes -I/usr/lib/jvm/java-8-openjdk-amd64//include
-I/usr/lib/jvm/java-8-openjdk-amd64//include/linux -c locks.c -o
locks.o
gcc -g -O2 -DOS_LINUX -DDSO_DLFCN -DCPU=\"amd64\" -Wall
-Wstrict-prototypes -I/usr/lib/jvm/java-8-openjdk-amd64//include
-I/usr/lib/jvm/java-8-openjdk-amd64//include/linux -c signals.c -o
signals.o
ar cr libservice.a arguments.o debug.o dso-dlfcn.o dso-dyld.o help.o
home.o java.o location.o replace.o locks.o signals.o
ranlib libservice.a
gcc jsvc-unix.o libservice.a -ldl -lpthread -o ../jsvc
make[1]: Leaving directory
'/mnt/c/test/commons-daemon-1.2.3-src/src/native/unix/native'
Gary
On Wed, Sep 9, 2020 at 5:39 AM Mark Thomas <ma...@apache.org> wrote:
>
> For those that aren't voting because the SHA512 hashes weren't included
> in the original VOTE here there are:
>
> #Release SHA-512s
> commons-daemon-1.2.3-bin.tar.gz=0d7ced8f5d6fd3e8781146ee47c37046c6ccd2f364138f89d137eea5f0255e1b2afae5faf7005164c077087cb08203fd44478d5c14c57c7df449feb324443447
> commons-daemon-1.2.3-native-src.tar.gz=5f223ee3c133f673fe698f575d7cfb15f27fbbb8acf2e6db292e0e1690a20d636b35312187aa1091b315062f2434788eec9cde167e2ae1d7e673ebdd2ddb41f6
> commons-daemon-1.2.3-native-src.zip=30e4066c70cf1096a1a881d3fbffa5c904efecb9fc921e0780dff9fbce9d007c2806c79d91a6351aafd38889a339742da6813ee6bd92da1716f05c4e9d0d35c4
> commons-daemon-1.2.3-src.zip=41bb51826f4c90d00091c258e03275142c64a33d898e65eea901fe00f7d75d13fcae4d783337c77bf5d4b6cda428bc12a092b28260c0c77b706e456ab410e14a
> commons-daemon-1.2.3-src.tar.gz=ddce2b90bd847f584f1d2207c5ed70b1554b9aa3a579821724a4e37d4bbaaf47425b85779216b449ee58ec9fdd38f4f3930080c8971febc7fca39dd3e73ace61
> commons-daemon-1.2.3-bin.zip=ac12a7621372bf4754b3f693bb262d3a137a6d396a24f4af170a256c518f609ccb85e6331aa2ed41a8e45babc68293dfe91045c51585c61f5ba46ed3e5422a33
> commons-daemon-1.2.3-bin-windows.zip=c79ee31a367addc5d49db474aabe084cebcd4f7f0f0f9ddc7999c02d4de5cd6ace6d5f55a230f399cfaaf780179b6f9808739efc7500b18c27cdb963daaef8d5
>
> Mark
>
>
> On 01/09/2020 19:25, Mark Thomas wrote:
> > Apologies for the slight delay between the tag and the vote. There was
> > an issue with the code signing service we use to sign the Windows binaries.
> >
> > It has been almost a year since the last Commons Daemon release. Notable
> > changes since 1.2.2 include:
> > - Improved debug logging for error conditions
> > - Added support for Java's Native Memory Tracing
> > - Added a procrun command to output the current configuration
> >
> > The full set of changes is in the changelog
> >
> > 1.2.3 RC1 can be obtained from (r41271)
> > https://dist.apache.org/repos/dist/dev/commons/daemon/
> >
> > The git tag is:
> > Tag: COMMONS_DAEMON_1_2_3_RC1
> > URL:
> > https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=f42d76aaa22df5f6bfa2f745ba2985bc47fe28d1
> > Hash: f42d76aaa22df5f6bfa2f745ba2985bc47fe28d1
> >
> > The Maven Staging repo is:
> > https://repository.apache.org/content/repositories/orgapachecommons-1525/
> >
> > The Windows binaries have been signed by the DigiCert (formerly
> > Symantec) code signing service.
> >
> > Files signed with my preferred key:
> > http://people.apache.org/~markt/
> > KEYS file is standard Apache Commons keys file:
> > http://www.apache.org/dist/commons/KEYS
> >
> >
> > [ ] Approved - go ahead and release Commons Daemon 1.2.3 RC1 as 1.2.3
> > [ ] Broken - do not release because...
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
