Le 24/10/2024 à 21:05, Gary Gregory a écrit :
Uh, no, don't be disingenuous by showing 3 lines, the commit is many pages long of diff. All of it is -1 as it increases the code complexity, increase code duplication, and adds the anti-pattern of throwing RuntimeException more than once.
My commit message could have been clearer, it actually reverted the commit 87e898fa [1] and replaced the reflection code with the snippet I mentioned. So the code doesn't come out of my hat, that's what commons-compress already had for years before.
Adding a dependency such as commons-lang3 has a significant impact for the users. In my case it broke an application that was using commons-compress but didn't have commons-lang3 on the classpath.
I understand your desire to reuse as much code as possible to ease the maintenance, but in this case the user's convenience outweighs the maintainer's convenience. commons-lang3 doesn't bring enough value in this case to justify its addition to the runtime dependencies.
Emmanuel Bourg [1] https://github.com/apache/commons-compress/commit/87e898fa --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
