On Sun, 17 Nov 2024 at 14:01, Gary Gregory <garydgreg...@gmail.com> wrote: > > Hi Niall, > > I don't think we are at an impasse: The PMC has approved release after > release, as recently as 1.27.1 three months ago. Emmanuel has not voted on > a Compress release in over eight years, since 1.11, that's 20 release votes > ignored.
So what? People come and go in Commons, and may change focus. > Doing drive-by copypasta commits long after releases wanting a time machine > is not OK IMO. It seems to me perfectly OK to question a commit regardless of when it happened. I think Emmanuel is within his rights to question whether adding the dependency was the right thing to do. > Gary > > On Sat, Nov 16, 2024, 3:42 PM Niall Pemberton <niall.pember...@gmail.com> > wrote: > > > On Fri, 1 Nov 2024 at 13:22, Gary D. Gregory <ggreg...@apache.org> wrote: > > > > > There has been no revert from the committer since the -1 on October 24, > > so > > > I will revert. This affects 11 Java files. This will revert the copy and > > > pasting of code patterns over and over. > > > > > > Seems we’re now at an impasses as Emmanuel has vetoed the commits > > introducing the dependencies earlier in the year. So are you now going to > > revert those? > > > > Niall > > > > > > > > > > > > > > Gary > > > > > > On 2024/10/24 21:17:41 Emmanuel Bourg wrote: > > > > Le 24/10/2024 à 21:05, Gary Gregory a écrit : > > > > > > > > > Uh, no, don't be disingenuous by showing 3 lines, the commit is many > > > pages > > > > > long of diff. All of it is -1 as it increases the code complexity, > > > increase > > > > > code duplication, and adds the anti-pattern of throwing > > > RuntimeException > > > > > more than once. > > > > > > > > My commit message could have been clearer, it actually reverted the > > > > commit 87e898fa [1] and replaced the reflection code with the snippet I > > > > mentioned. So the code doesn't come out of my hat, that's what > > > > commons-compress already had for years before. > > > > > > > > Adding a dependency such as commons-lang3 has a significant impact for > > > > the users. In my case it broke an application that was using > > > > commons-compress but didn't have commons-lang3 on the classpath. > > > > > > > > I understand your desire to reuse as much code as possible to ease the > > > > maintenance, but in this case the user's convenience outweighs the > > > > maintainer's convenience. commons-lang3 doesn't bring enough value in > > > > this case to justify its addition to the runtime dependencies. > > > > > > > > Emmanuel Bourg > > > > > > > > [1] https://github.com/apache/commons-compress/commit/87e898fa > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
