Le 17/11/2024 à 23:57, sebb a écrit :
It seems to me perfectly OK to question a commit regardless of when it happened.
I think Emmanuel is within his rights to question whether adding the
dependency was the right thing to do.
And I think I'm not the only one surprised by the new dependencies. I
stumbled on this commit from Torsten Curdt, another Commons Compress
contributor, in its jdeb project. The comment in the pom.xml is quite clear:
https://github.com/tcurdt/jdeb/commit/743e5d7f
From 743e5d7f387098c1d1190189f7636045a0fe004a Mon Sep 17 00:00:00 2001
From: Torsten Curdt <tcu...@vafer.org>
Date: Sun, 2 Jun 2024 21:30:34 +0200
Subject: [PATCH] working around a dep issue with compress
---
pom.xml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/pom.xml b/pom.xml
index 671f4bfce..7ea500b60 100644
--- a/pom.xml
+++ b/pom.xml
@@ -146,6 +146,12 @@
<artifactId>commons-compress</artifactId>
<version>1.26.2</version>
</dependency>
+ <dependency>
+ <!-- this should not be required but somehow compress introduced
the dep -->
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <version>3.14.0</version>
+ </dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcpg-jdk15on</artifactId>
@@ -357,6 +363,7 @@
<include>org.apache.commons:commons-compress</include>
<include>commons-codec:commons-codec</include>
<include>commons-io:commons-io</include>
+ <include>org.apache.commons:commons-lang3</include>
<include>org.bouncycastle:bcpg-jdk15on</include>
<include>org.bouncycastle:bcprov-jdk15on</include>
<include>org.tukaani:xz</include>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
