Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/143#discussion_r22887184
--- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java ---
@@ -89,6 +97,15 @@ public void setWebView(CordovaWebView view) {
this.appView = view;
helper = new CordovaUriHelper(cordova, view);
}
+
+ /**
+ * Specifies the HTTP auth handler for handling auth challenge
requests.
+ *
+ * @param handler HTTP auth handler.
+ */
+ public void setHttpAuthRequestHandler(HttpAuthRequestHandler handler) {
--- End diff --
Why use a setter here instead of following the plugin pattern of allowing
all plugins to handle the callback?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
