Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/143#discussion_r22909913
  
    --- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java ---
    @@ -89,6 +97,15 @@ public void setWebView(CordovaWebView view) {
             this.appView = view;
             helper = new CordovaUriHelper(cordova, view);
         }
    +    
    +    /**
    +     * Specifies the HTTP auth handler for handling auth challenge 
requests.
    +     *
    +     * @param handler HTTP auth handler.
    +     */
    +    public void setHttpAuthRequestHandler(HttpAuthRequestHandler handler) {
    --- End diff --
    
    Right now, almost all plugin hooks are implemented by adding a method to 
CordovaPlugin and PluginManager (which loops over all plugins and calls the 
corresponding CordovaPlugin method).
    
    Calling plugins based on what interfaces they implement is a neat idea, 
although it'd be a new concept to the project. I'm not actually sure if there 
are benefits to it or not! Likely we could use that info to improve performance 
a bit, but perf isn't an issue atm afaik.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to