Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/143#discussion_r23058226
  
    --- Diff: framework/src/org/apache/cordova/PluginManager.java ---
    @@ -243,6 +243,27 @@ public void onPause(boolean multitasking) {
         }
     
         /**
    +     * Called when the system received an HTTP authentication request. 
Plugins can use
    +     * the supplied HttpAuthHandler to process this auth challenge.
    +     *
    +     * @param view              The WebView that is initiating the callback
    +     * @param handler           The HttpAuthHandler used to set the 
WebView's response
    +     * @param host              The host requiring authentication
    +     * @param realm             The realm for which authentication is 
required
    +     * 
    +     * @return                  Return True if there is a plugin which 
will resolve this auth challenge, otherwise False
    +     * 
    +     */
    +    public Boolean onReceivedHttpAuthRequest(CordovaWebView view, 
ICordovaHttpAuthHandler handler, String host, String realm) {
    --- End diff --
    
    Unless you want this to be tri-state, then "Boolean" should be "boolean". I 
don't see the need for tristate, so go with "boolean"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to