Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27536261
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -402,6 +440,16 @@ function parseOpts(options, resolvedTarget) {
case 'gradleArg':
ret.extraArgs.push(flagValue);
break;
+ case 'keystore':
+ case 'alias':
+ case 'keytorePassword':
+ case 'password':
+ case 'keystoreType':
+ packageArgs[flagName] = flagValue;
+ break;
+ case 'buildConfig':
+ buildConfig = flagValue.replace(/"/g, '');
--- End diff --
Quotes for these reasons are generally interpreted by the shell (cmd.exe),
and when we see it here, they should be gone already (and flagValue will have a
space in it).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
