Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/164#discussion_r27590209
  
    --- Diff: bin/templates/cordova/lib/build.js ---
    @@ -402,6 +440,16 @@ function parseOpts(options, resolvedTarget) {
                     case 'gradleArg':
                         ret.extraArgs.push(flagValue);
                         break;
    +                case 'keystore':
    +                case 'alias':
    +                case 'keytorePassword':
    +                case 'password':
    +                case 'keystoreType':
    +                    packageArgs[flagName] = flagValue;
    +                    break;
    +                case 'buildConfig':
    +                    buildConfig = flagValue.replace(/"/g, '');
    --- End diff --
    
    My previous statement is not true. I think I found my issue where I was 
explicitly adding quotes in cordova-lib code which was escaped by superspawn. I 
do not need this and will remove it. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to