Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27536475
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +500,18 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean = function(options) {
var opts = parseOpts(options);
var builder = builders[opts.buildMethod];
- return builder.prepEnv()
+ return builder.prepEnv(opts)
.then(function() {
- return builder.clean(opts.extraArgs);
+ return builder.clean(opts);
}).then(function() {
shell.rm('-rf', path.join(ROOT, 'out'));
+
+ ['debug', 'release'].forEach(function(config) {
+ var propertiesFilePath = path.join(ROOT, config +
SIGNING_PROPERTIES);
+ if(isAutoGenerated(propertiesFilePath)){
+ shell.rm('-f', propertiesFilePath);
--- End diff --
prepEnv (which is called in this case) takes care of deleting these if
there is no supplied signing args. I don't think there's a need to delete them
unconditionally since we don't bother deleting other build-time-supplied-files
(like build.xml, build.gradle)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
