[ 
https://issues.apache.org/jira/browse/COUCHDB-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771751#action_12771751
 ] 

Paul Joseph Davis commented on COUCHDB-547:
-------------------------------------------

Joshua,

Patch looks mostly good. Couple things:

1. When you're not on a design doc the disabled "Compact View" button shouldn't 
be visible.
2. The compact view should probably be to the right of "Delete Database" to 
make sure that DB operations are grouped. Plus it'll help as "Compact View" 
isn't always visible, thus lessening confusion if buttons moved.
3. The dialog box text needs a bit of work:

"Compacting a view removes deleted documents and previous revisions. It is an 
irreversible operation and may take a while to complete for large views."

Should read something like:

"View compaction will affect all views in this design document. This operation 
may take some time to complete. Your views will still operate normally during 
compaction."

Or some such. Deleting and removing and revisions and irreversible are all 
things that people shouldn't be forced to consider when doing view compaction 
because none of those are remotely related.

Other than those minor tweaks, it looks good to me.

> add "compact view" button to futon
> ----------------------------------
>
>                 Key: COUCHDB-547
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-547
>             Project: CouchDB
>          Issue Type: New Feature
>          Components: HTTP Interface
>            Reporter: Joshua Bronson
>            Priority: Minor
>         Attachments: compactviewbutton.diff
>
>
> The attached patch, created via "git diff --binary 
> 1b2855063bc6ddccb6a7003a7243930678673ba7... > compactviewbutton.diff" from 
> within a clone of git://github.com/jab/couchdb.git (see 
> http://github.com/jab/couchdb), adds a "compact view" button to futon when 
> browsing a view.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to