[
https://issues.apache.org/jira/browse/COUCHDB-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771753#action_12771753
]
Joshua Bronson commented on COUCHDB-547:
----------------------------------------
> Patch looks mostly good
glad to hear it!
> 1. When you're not on a design doc the disabled "Compact View" button
> shouldn't be visible.
Oh, I brought it up in the channel today and kocolosk said it should be grayed
out rather than hidden, so I added the "button.disabled" stuff you'll notice in
layout.css and database.html. Also, I added a fourth sprite to the bottom of
compact.png so the button would look disabled; did this make it through when
you applied the attached patch? I noticed it says "GIT binary patch" in the
attached where it gives the hunk(?) for compact.png, wonder whether that means
you have to use git-apply to get this part of the patch to work?
> 2. The compact view should probably be to the right of "Delete Database" to
> make sure that DB operations are grouped. Plus it'll help as "Compact View"
> isn't always visible, thus lessening confusion if buttons moved.
> 3. The dialog box text needs a bit of work:
<snip/>
Both 2 and 3 sound good to me. Want me to make the changes and resubmit the
patch?
> add "compact view" button to futon
> ----------------------------------
>
> Key: COUCHDB-547
> URL: https://issues.apache.org/jira/browse/COUCHDB-547
> Project: CouchDB
> Issue Type: New Feature
> Components: HTTP Interface
> Reporter: Joshua Bronson
> Priority: Minor
> Attachments: compactviewbutton.diff
>
>
> The attached patch, created via "git diff --binary
> 1b2855063bc6ddccb6a7003a7243930678673ba7... > compactviewbutton.diff" from
> within a clone of git://github.com/jab/couchdb.git (see
> http://github.com/jab/couchdb), adds a "compact view" button to futon when
> browsing a view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
