On Thu, Jan 19, 2012 at 13:38, Robert Newson <[email protected]> wrote: > I'd like to merge the persistent cookies feature (COUCHDB-1304) into > 1.2.x if it's not too late.
+1 > > B. > > On 16 January 2012 11:26, Robert Newson <[email protected]> wrote: >> I merged master so I can't be positive which commit is the fix yet but >> this one looks likely: >> https://github.com/cmullaparthi/ibrowse/commit/e05aa73f1acbfe877f7f0b6214f572b5a42b3db8 >> >> B. >> >> On 16 January 2012 01:09, Filipe David Manana <[email protected]> wrote: >>> On Sunday, January 15, 2012, Robert Newson <[email protected]> wrote: >>>> I'd say it's too late for the ibrowse fix but we should pick it up for 1.3 >>> >>> Can you point us to what that ibrowse fix is (e.g. Github commit link)? >>> As far as I can see there are no fixes upstream that we don't have in 1.2.x >>> Thanks >>> >>>> >>>> B. >>>> >>>> On 15 January 2012 21:31, Noah Slater <[email protected]> wrote: >>>>> I await your feedback. >>>>> >>>>> On Sun, Jan 15, 2012 at 7:46 PM, Robert Newson <[email protected]> >>> wrote: >>>>> >>>>>> If it's a regression, before. If not, after. >>>>>> >>>>>> B. >>>>>> >>>>>> On 15 January 2012 19:40, Noah Slater <[email protected]> wrote: >>>>>> > Are we going to punt on a Windows binary, Dave? >>>>>> > >>>>>> > On Sun, Jan 15, 2012 at 7:05 PM, Dave Cottlehuber <[email protected]> >>>>>> wrote: >>>>>> > >>>>>> >> On 15 January 2012 19:05, Noah Slater <[email protected]> wrote: >>>>>> >> > Bump. Dave? Gonna move without if you don't speak up. :) >>>>>> >> >>>>>> >> Sorry!! Literally *just* finished looking at this. >>>>>> >> >>>>>> >> TL;DR - let's roll 1.2.0. >>>>>> >> >>>>>> >> I don't see any *functional* issues in the failures from the test >>>>>> >> suite - attachments are written, and read, correctly. For some as yet >>>>>> >> unknown reason the MD5 is different on Windows vs Linux & Mac OS, but >>>>>> >> this has been present for some time. It's only turned up as a result >>>>>> >> of additional tests applied in COUCHDB-1337. >>>>>> >> >>>>>> >> The underlying crypto:md5 values are the same, and so is the raw HTTP >>>>>> >> data. I am still digging through mochi to where this comes from. >>>>>> >> >>>>>> >> I don't see any issues for replication - can anybody confirm? This >>>>>> >> looks like a dev issue rather than user impacting. >>>>>> >> >>>>>> >> from 1.1.1_js-1.8.0: >>>>>> >> 12> Digest = base64:encode(Digest_Binary). >>>>>> >> <<"jeLnIuUvK7d+6gya044lVA==">> >>>>>> >> >>>>>> >> from 1.2.x: >>>>>> >> 8> Digest = base64:encode(Digest_Binary). >>>>>> >> <<"jeLnIuUvK7d+6gya044lVA==">> >>>>>> >> >>>>>> >> A+ >>>>>> >> Dave >>>>>> >> >>>>>> >>>> >>> >>> -- >>> Filipe David Manana, >>> >>> "Reasonable men adapt themselves to the world. >>> Unreasonable men adapt the world to themselves. >>> That's why all progress depends on unreasonable men."
