Github user bradnoble commented on the pull request:
https://github.com/apache/couchdb/pull/251#issuecomment-46872912
Great idea. A couple comments from a UX perspective:
1. We need to bring the button to trigger the modal closer to the row of
the cursor. To the left of the column where the error indicator lives seems
viable. (We can't put it in the same column as the error indicator b/c we need
to be able to allow the user to pop up the editor for a value that has an
error.)
1. The button should only appear on the row where the cursor is. (In other
words, we shouldn't see an icon next to every row.)
1. Would prefer an alt-edit or a modal icon, rather than a keyboard.
Keyboard isn't precise enough, as every edit action inside the editor involves
the keyboard. One could make the same argument against an edit icon, so an
alt-edit (something custom, probably) or a modal/window icon could work.
Questions:
1. Will the editor pop up even when a user has an error? For example, what
about a value that doesn't have a closing quote? Will the user have to use ACE
to fix that before popping the value editor?
1. What happens when a user has selected with her cursor more than one
value (ie more than one row)? Does the editor icon not appear?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
