Github user davisp commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/4#discussion_r19236997
--- Diff: src/couch_changes.erl ---
@@ -332,24 +444,52 @@ build_acc(Args, Callback, UserAcc, Db, StartSeq,
Prepend, Timeout, TimeoutFun) -
doc_options = DocOpts,
conflicts = Conflicts,
timeout = Timeout,
- timeout_fun = TimeoutFun
+ timeout_fun = TimeoutFun,
+ ddoc_name = DDocName,
+ view_name = ViewName,
+ view = View,
+ aggregation_results=[],
+ aggregation_kvs=[]
}.
-send_changes(Args, Acc0, FirstRound) ->
- #changes_args{
- dir = Dir
- } = Args,
+send_changes(Acc, Dir, FirstRound) ->
#changes_acc{
db = Db,
seq = StartSeq,
- filter = Filter
- } = Acc0,
- EnumFun = fun ?MODULE:changes_enumerator/2,
+ filter = Filter,
+ view = View
+ } = Acc,
+ DbEnumFun = fun changes_enumerator/2,
--- End diff --
Probably not in this case as changes enumeration is a short lived thing.
For continuous changes feeds we re-enter this function periodically. Leaving
off the ?MODULE means we wouldn't have to handle upgrades between every
invocation of changes_enumerator/2. Granted it appears to be an accidental
change here so that could just be an oddity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
