ottlinger commented on code in PR #558:
URL: https://github.com/apache/creadur-rat/pull/558#discussion_r2444019045


##########
apache-rat-core/src/main/java/org/apache/rat/config/exclusion/StandardCollection.java:
##########
@@ -86,7 +86,7 @@ null, new CVSIgnoreBuilder()),
      */
     ECLIPSE("The files and directories created by an Eclipse IDE based tool.",
             Arrays.asList("**/.checkstyle", "**/.classpath", "**/.factorypath",
-                    "**/.project", "**/.settings/**", 
"**/.externalToolBuilders"),
+                    "**/.project", "**/.settings/**", 
"**/.externalToolBuilders/**"),

Review Comment:
   Should we add this '**/bin/' as well to include Eclipse's default binary 
directory? WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to