ottlinger commented on code in PR #558:
URL: https://github.com/apache/creadur-rat/pull/558#discussion_r2449595547
##########
apache-rat-core/pom.xml:
##########
@@ -44,20 +44,17 @@
<artifactId>apache-rat-plugin</artifactId>
<configuration>
<inputExcludes>
- <!-- remove if RAT-501 is fixed -->
+ <!-- exclude the definition file(s) -->
<exclude>**/default.xml</exclude>
<exclude>**/example-configuration.xml</exclude>
+ <!-- exclude test generation files that contain unapproved
license text -->
<exclude>**/ReporterOptionsProvider.java</exclude>
<exclude>**/GPLLicenseTest.java</exclude>
- <!-- /remove if RAT-501 is fixed -->
<!-- Generated by Eclipse, and not distributed, so ignorable. -->
- <exclude>bin/**/*</exclude>
- <exclude>.externalToolBuilders/**/*</exclude>
+ <exclude>bin/**/*</exclude>-->
Review Comment:
@Claudenw would you be so kind to fix the "-->" at the end of the line and
add a comment that this entry can be removed after updating to releases >0.17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
