Claudenw commented on code in PR #558:
URL: https://github.com/apache/creadur-rat/pull/558#discussion_r2444127117


##########
apache-rat-core/src/main/java/org/apache/rat/config/exclusion/StandardCollection.java:
##########
@@ -86,7 +86,7 @@ null, new CVSIgnoreBuilder()),
      */
     ECLIPSE("The files and directories created by an Eclipse IDE based tool.",
             Arrays.asList("**/.checkstyle", "**/.classpath", "**/.factorypath",
-                    "**/.project", "**/.settings/**", 
"**/.externalToolBuilders"),
+                    "**/.project", "**/.settings/**", 
"**/.externalToolBuilders/**"),

Review Comment:
   I think that **/bin may be an issue.  does eclipse always create it?  I 
think we need some research into the impact of excluding **/bin.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to