[ 
https://issues.apache.org/jira/browse/CURATOR-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821982#comment-15821982
 ] 

ASF GitHub Bot commented on CURATOR-200:
----------------------------------------

Github user Randgalt commented on the issue:

    https://github.com/apache/curator/pull/190
  
    I don't know OSGI so I can't speak to that. But, Guava is relocated in this 
PR - that's the point of it. Notice the `relocation` tags in the pom file.


> Proposal: Remove references to guava library from public APIs
> -------------------------------------------------------------
>
>                 Key: CURATOR-200
>                 URL: https://issues.apache.org/jira/browse/CURATOR-200
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Framework
>            Reporter: Mike Drob
>            Assignee: Jordan Zimmerman
>             Fix For: 3.3.0, 2.12.0
>
>
> There was a good discussion on the mailing list: 
> http://curator.markmail.org/thread/yjete2ozm32jmz5u
> The critical portion copied here:
> {quote}
> The problem classes that I have found are:
> * curator-framework: org.apache.curator.framework.listen.ListenerContainer : 
> method forEach takes a parameter of type com.google.common.base.Function
> * curator-framework: 
> org.apache.curator.framework.api.transaction.CuratorTransactionResult : 
> method ofTypeAndPath returns com.google.common.base.Predicate
> * curator-x-discovery-server: 
> org.apache.curator.x.discovery.server.contexts.GenericDiscoveryContext : 
> constructor takes param of type com.google.common.reflect.TypeToken
> * curator-x-discovery: org.apache.curator.x.discovery.InstanceFilter : 
> inherits from com.google.common.base.Predicate
> {quote}
> In the ensuing discussion, it sounded like we'd need to get started on an 
> implementation before we had enough information to determine whether the 
> changes are too intrusive or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to