[
https://issues.apache.org/jira/browse/CURATOR-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963298#comment-15963298
]
ASF GitHub Bot commented on CURATOR-200:
----------------------------------------
GitHub user lucasmo opened a pull request:
https://github.com/apache/curator/pull/212
Fix guava version incompatibility with MoreExecutors.sameThreadExecutor()
Before I went to create this PR, I see similar ones have been closed
several times, suggesting that it was addressed in
https://github.com/apache/curator/pull/190 as part of
https://issues.apache.org/jira/browse/CURATOR-200
This doesn't appear to actually address the issue, as this error occurs:
```
java.lang.NoSuchMethodError:
com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor()Lcom/google/common/util/concurrent/ListeningExecutorService;
at
org.apache.curator.framework.listen.ListenerContainer.addListener(ListenerContainer.java:40)
at
org.apache.curator.framework.imps.CuratorFrameworkImpl.start(CuratorFrameworkImpl.java:256)
at XXX.start(XXX.java:88)
```
I'm not familiar with shading, but it appears it's either not implemented
or not working properly in this case (does shading rewrite the curator source
files?). This error occurs with both 2.12.0 and 3.3.0.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lucasmo/curator master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/212.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #212
----
commit cf40b506470930f71eb1f47a210a9d5fb9fc0b60
Author: Lucas Fairchild-Madar <[email protected]>
Date: 2017-04-10T18:12:31Z
Replace calls to MoreExecutors.sameThreadExecutor() with
MoreExecutors.directExecutor()
commit 612dde623f6c6443616ee963aef82d331782479c
Author: Lucas Fairchild-Madar <[email protected]>
Date: 2017-04-10T18:14:35Z
Bump to minimum guava version that has MoreExecutors.directExecutor()
commit 6d050b8ec694861336aa6620f9ca8b3aa06dc605
Author: lucasmo <[email protected]>
Date: 2017-04-10T18:16:58Z
Update QueueBuilder.java
----
> Proposal: Remove references to guava library from public APIs
> -------------------------------------------------------------
>
> Key: CURATOR-200
> URL: https://issues.apache.org/jira/browse/CURATOR-200
> Project: Apache Curator
> Issue Type: Improvement
> Components: Framework
> Reporter: Mike Drob
> Assignee: Jordan Zimmerman
> Fix For: 3.3.0, 2.12.0
>
>
> There was a good discussion on the mailing list:
> http://curator.markmail.org/thread/yjete2ozm32jmz5u
> The critical portion copied here:
> {quote}
> The problem classes that I have found are:
> * curator-framework: org.apache.curator.framework.listen.ListenerContainer :
> method forEach takes a parameter of type com.google.common.base.Function
> * curator-framework:
> org.apache.curator.framework.api.transaction.CuratorTransactionResult :
> method ofTypeAndPath returns com.google.common.base.Predicate
> * curator-x-discovery-server:
> org.apache.curator.x.discovery.server.contexts.GenericDiscoveryContext :
> constructor takes param of type com.google.common.reflect.TypeToken
> * curator-x-discovery: org.apache.curator.x.discovery.InstanceFilter :
> inherits from com.google.common.base.Predicate
> {quote}
> In the ensuing discussion, it sounded like we'd need to get started on an
> implementation before we had enough information to determine whether the
> changes are too intrusive or not.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
