[ 
https://issues.apache.org/jira/browse/CURATOR-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561312#comment-16561312
 ] 

Cameron McKenzie commented on CURATOR-472:
------------------------------------------

Thanks for the update. So, my initial thoughts are that this is a Zookeeper 
issue. Either, it's a documentation issue in that the public API they're 
exposing makes no mention of the close(int) method not being safe for clients 
to call. Or, there's an actual issue with the shutdown process.

It doesn't appear the Curator is doing anything strange with its interaction 
with ZK. Thoughts?

> Test-only code started to be called in prod
> -------------------------------------------
>
>                 Key: CURATOR-472
>                 URL: https://issues.apache.org/jira/browse/CURATOR-472
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Client
>            Reporter: mskonovalov
>            Assignee: Cameron McKenzie
>            Priority: Critical
>
> After commit {{fe2c7c4cd606c0cf4bc4fab15deedc0f4c33ea0e}} the method
>  
> {code:java}
> protected boolean testableWaitForShutdown(int wait)
>     throws InterruptedException
> {code}
> with the following comment
>  
>  
> {code:java}
> * Wait up to wait milliseconds for the underlying threads to shutdown.
> * THIS METHOD IS EXPECTED TO BE USED FOR TESTING ONLY!!!
> {code}
> started to be called from real method {{ZooKeeper.close()}}
> It prevents tests to finish.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to