[
https://issues.apache.org/jira/browse/CURATOR-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705876#comment-16705876
]
ASF GitHub Bot commented on CURATOR-472:
----------------------------------------
GitHub user Randgalt opened a pull request:
https://github.com/apache/curator/pull/283
CURATOR-472 - fix deadlocks during tests as well as TTL test issues
Fixed 2 problems: 1) internalClose can be called from a ZooKeeper
background thread (as part of a Watcher callback). Calling ZooKeeper.close with
a waitForShutdownTimeoutMs in this case will cause a deadlock as no other
events can be processed until the current thread exits. 2) All TTL tests must
set the system property "zookeeper.extendedTypesEnabled"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/curator CURATOR-472
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/283.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #283
----
commit b91036be07aaddc4ed2d81615b08b33075e923af
Author: randgalt <randgalt@...>
Date: 2018-12-01T15:55:55Z
CURATOR-472
Fixed 2 problems: 1) internalClose can be called from a ZooKeeper
background thread (as part of a Watcher callback). Calling ZooKeeper.close with
a waitForShutdownTimeoutMs in this case will cause a deadlock as no other
events can be processed until the current thread exits. 2) All TTL tests must
set the system property "zookeeper.extendedTypesEnabled"
----
> Test-only code started to be called in prod
> -------------------------------------------
>
> Key: CURATOR-472
> URL: https://issues.apache.org/jira/browse/CURATOR-472
> Project: Apache Curator
> Issue Type: Bug
> Components: Client
> Reporter: mskonovalov
> Assignee: Cameron McKenzie
> Priority: Critical
>
> After commit {{fe2c7c4cd606c0cf4bc4fab15deedc0f4c33ea0e}} the method
>
> {code:java}
> protected boolean testableWaitForShutdown(int wait)
> throws InterruptedException
> {code}
> with the following comment
>
>
> {code:java}
> * Wait up to wait milliseconds for the underlying threads to shutdown.
> * THIS METHOD IS EXPECTED TO BE USED FOR TESTING ONLY!!!
> {code}
> started to be called from real method {{ZooKeeper.close()}}
> It prevents tests to finish.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
