[
https://issues.apache.org/jira/browse/CURATOR-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706513#comment-16706513
]
ASF GitHub Bot commented on CURATOR-472:
----------------------------------------
Github user cammckenzie commented on the issue:
https://github.com/apache/curator/pull/283
Looks good to me. I pushed a fixed to the TestTtlNodes unit test is it was
consistently failing for me.
> Test-only code started to be called in prod
> -------------------------------------------
>
> Key: CURATOR-472
> URL: https://issues.apache.org/jira/browse/CURATOR-472
> Project: Apache Curator
> Issue Type: Bug
> Components: Client
> Reporter: mskonovalov
> Assignee: Cameron McKenzie
> Priority: Critical
>
> After commit {{fe2c7c4cd606c0cf4bc4fab15deedc0f4c33ea0e}} the method
>
> {code:java}
> protected boolean testableWaitForShutdown(int wait)
> throws InterruptedException
> {code}
> with the following comment
>
>
> {code:java}
> * Wait up to wait milliseconds for the underlying threads to shutdown.
> * THIS METHOD IS EXPECTED TO BE USED FOR TESTING ONLY!!!
> {code}
> started to be called from real method {{ZooKeeper.close()}}
> It prevents tests to finish.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
