[
https://issues.apache.org/jira/browse/CURATOR-558?focusedWorklogId=403502&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403502
]
ASF GitHub Bot logged work on CURATOR-558:
------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Mar/20 21:46
Start Date: 14/Mar/20 21:46
Worklog Time Spent: 10m
Work Description: TisonKun commented on pull request #344: CURATOR-558 -
part 1 of ZK 3.6 updates
URL: https://github.com/apache/curator/pull/344#discussion_r392621920
##########
File path:
curator-recipes/src/test/java/org/apache/curator/framework/recipes/cache/TestTreeCache.java
##########
@@ -423,9 +423,9 @@ public void testKilledSession() throws Exception
client.create().withMode(CreateMode.EPHEMERAL).forPath("/test/me",
"data".getBytes());
assertEvent(TreeCacheEvent.Type.NODE_ADDED, "/test/me");
-
Compatibility.injectSessionExpiration(client.getZookeeperClient().getZooKeeper());
- assertEvent(TreeCacheEvent.Type.NODE_REMOVED, "/test/me",
"data".getBytes(), true);
+
client.getZookeeperClient().getZooKeeper().getTestable().injectSessionExpiration();
assertEvent(TreeCacheEvent.Type.INITIALIZED, null, null, true);
+ assertEvent(TreeCacheEvent.Type.NODE_REMOVED, "/test/me",
"data".getBytes(), true);
Review comment:
Interesting. The different is that zookeeper's testable has these additional
lines
```java
this.clientCnxn.eventThread.queueEventOfDeath();
this.clientCnxn.state = States.CLOSED;
this.clientCnxn.sendThread.getClientCnxnSocket().onClosing();
```
where both of them calls
```java
this.clientCnxn.eventThread.queueEvent(new WatchedEvent(EventType.None,
KeeperState.Expired, (String)null));
```
I'm not very sure how it changes the behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 403502)
Time Spent: 1.5h (was: 1h 20m)
> ZooKeeper 3.6.0 has many API changes - bring Curator up to date
> ---------------------------------------------------------------
>
> Key: CURATOR-558
> URL: https://issues.apache.org/jira/browse/CURATOR-558
> Project: Apache Curator
> Issue Type: Improvement
> Components: Client, Documentation, Framework, Tests
> Affects Versions: 4.2.0
> Reporter: Jordan Zimmerman
> Priority: Major
> Fix For: 5.0.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> ZooKeeper 3.6.0 (soon to be released) has a number of internal changes that
> require significant changes to Curator. We should consider:
> * Major version bump (5.0? 4.4?)
> * Remove ZK 3.4 compatibility code - Curator 4.2.x can remain the supported
> version for 3.4 compatibility
> * Should we remove the few Guava classes that have leaked into our public
> APIs? {{ListenerContainer}} has been deprecated for a version or two now.
> * We can also remove the "Reaper" classes which are no longer necessary given
> Container nodes
> * Remove Exhibitor support
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
