[
https://issues.apache.org/jira/browse/CURATOR-558?focusedWorklogId=403692&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403692
]
ASF GitHub Bot logged work on CURATOR-558:
------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Mar/20 01:50
Start Date: 16/Mar/20 01:50
Worklog Time Spent: 10m
Work Description: TisonKun commented on pull request #350: [CURATOR-558]
- Updates for ZooKeeper 3.6.0
URL: https://github.com/apache/curator/pull/350#discussion_r392746349
##########
File path:
curator-client/src/main/java/org/apache/curator/utils/Compatibility.java
##########
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.curator.utils;
+
+import org.apache.zookeeper.server.quorum.QuorumPeer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import java.lang.reflect.Field;
+import java.lang.reflect.Method;
+import java.net.InetSocketAddress;
+
+/**
+ * Utils to help with ZK version compatibility
+ */
+public class Compatibility
+{
+ private static final Method getReachableOrOneMethod;
+ private static final Field addrField;
+
+ private static final Logger log =
LoggerFactory.getLogger(Compatibility.class);
+
+ static
+ {
+ Method localGetReachableOrOneMethod;
+ try
+ {
+ Class<?> multipleAddressesClass =
Class.forName("org.apache.zookeeper.server.quorum.MultipleAddresses");
+ localGetReachableOrOneMethod =
multipleAddressesClass.getMethod("getReachableOrOne");
+ LoggerFactory.getLogger(Compatibility.class).info("Using
org.apache.zookeeper.server.quorum.MultipleAddresses");
Review comment:
```suggestion
log.info("Using
org.apache.zookeeper.server.quorum.MultipleAddresses");
```
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 403692)
Time Spent: 2.5h (was: 2h 20m)
> ZooKeeper 3.6.0 has many API changes - bring Curator up to date
> ---------------------------------------------------------------
>
> Key: CURATOR-558
> URL: https://issues.apache.org/jira/browse/CURATOR-558
> Project: Apache Curator
> Issue Type: Improvement
> Components: Client, Documentation, Framework, Tests
> Affects Versions: 4.2.0
> Reporter: Jordan Zimmerman
> Priority: Major
> Fix For: 5.0.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> ZooKeeper 3.6.0 (soon to be released) has a number of internal changes that
> require significant changes to Curator. We should consider:
> * Major version bump (5.0? 4.4?)
> * Remove ZK 3.4 compatibility code - Curator 4.2.x can remain the supported
> version for 3.4 compatibility
> * Should we remove the few Guava classes that have leaked into our public
> APIs? {{ListenerContainer}} has been deprecated for a version or two now.
> * We can also remove the "Reaper" classes which are no longer necessary given
> Container nodes
> * Remove Exhibitor support
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
