[
https://issues.apache.org/jira/browse/CURATOR-558?focusedWorklogId=403604&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403604
]
ASF GitHub Bot logged work on CURATOR-558:
------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/20 13:54
Start Date: 15/Mar/20 13:54
Worklog Time Spent: 10m
Work Description: Randgalt commented on pull request #350: [CURATOR-558]
- Updates for ZooKeeper 3.6.0
URL: https://github.com/apache/curator/pull/350
### 3.6.0 has many changes
ZooKeeper 3.6.0 has some significant changes from previous versions and this
PR is only bringing Curator up to date. Some of these changes are:
- The reconfig APIs have moved into a new class, `ZooKeeperAdmin`. This
class existed in 3.5.x but wasn't required. Now it is.
- `DefaultZookeeperFactory` now checks `Compatibility.hasZooKeeperAdmin()`
and creates a `ZooKeeperAdmin` if it's available
- A bunch of little things changed in the ZK server code which affected
Curator's test classes. I moved it all into reflection based calls in
`Compatibility.java` in the test module. We now have modules that test ZK 3.4,
3.5 and 3.6 so we're safe with compatibility.
- ZooKeeper's `MultiTransactionRecord` has been removed it seems. That
forced `CuratorMultiTransactionRecord` to be re-written. It's not a public
class so hopefully it won't affect anyone.
### New module
There is a new module, `curator-test-zk35`. It forces ZooKeeper 3.5.7 and
performs selected tests from the other modules to ensure compatibility. Tests
annotated with TestNG groups `zk35` and `zk35Compatibility` are tested. Group
`zk36` is excluded. Note: these tests will only run from Maven. I don't think
IntelliJ/Eclipse support the Maven syntax I used.
### 3 More PRs coming
I have 3 more PRs that will be separate from this to avoid too much review
pain:
- #334
- #335
- #336
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 403604)
Time Spent: 2h (was: 1h 50m)
> ZooKeeper 3.6.0 has many API changes - bring Curator up to date
> ---------------------------------------------------------------
>
> Key: CURATOR-558
> URL: https://issues.apache.org/jira/browse/CURATOR-558
> Project: Apache Curator
> Issue Type: Improvement
> Components: Client, Documentation, Framework, Tests
> Affects Versions: 4.2.0
> Reporter: Jordan Zimmerman
> Priority: Major
> Fix For: 5.0.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> ZooKeeper 3.6.0 (soon to be released) has a number of internal changes that
> require significant changes to Curator. We should consider:
> * Major version bump (5.0? 4.4?)
> * Remove ZK 3.4 compatibility code - Curator 4.2.x can remain the supported
> version for 3.4 compatibility
> * Should we remove the few Guava classes that have leaked into our public
> APIs? {{ListenerContainer}} has been deprecated for a version or two now.
> * We can also remove the "Reaper" classes which are no longer necessary given
> Container nodes
> * Remove Exhibitor support
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
