reta commented on issue #619: CXF-8188: Inject into ClientHeadersFactory URL: https://github.com/apache/cxf/pull/619#issuecomment-573453118 hey @andymc12, sorry for the delay, finally found the time to finish the review: - `CDIUtils` and `CDIFacade`: we already use reflection-base `BeanManager` detection in `CDIInterceptorWrapper::createWrapper`, it think we should stick to one way to do it - may be `MicroProfileClientFactoryBean` is a better place for dealing with CDI & `ClientHeadersFactory`, which could be passed to `MicroProfileClientProxyImpl` in a similar way as `CDIInterceptorWrapper`. The `BeanManager` detection logic (whichever we pick), could be reused for both of them. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
