reta commented on issue #619: CXF-8188: Inject into ClientHeadersFactory
URL: https://github.com/apache/cxf/pull/619#issuecomment-573945176
 
 
   Thanks @andymc12 , regarding
   
   > My latest changes reuse the BeanManager detection logic. I'm not sure if 
moving the ClientHeadersFactory logic into MicroProfileClientFactoryBean will 
work since that is when the client proxy is being created. It's possible the 
the rest client instance is created in one JAX-RS context (or outside of a 
JAX-RS request entirely) and then used in a different JAX-RS context. So then 
the injection would need to occur on each request, right?
   
   you are right, it might happen, but probably the same would apply to 
`CDIInterceptorWrapper`: it will pick up the interceptors from the different 
context. I don't know what is the best option to be fair, just an opinion if we 
have a single place to make the decisions (the factory bean), it would be much 
easier to reason about the outcome (proxy) and maintain it. The uncertainty 
with contexts may cause issues but I would leave the decision to you, I think 
you have a better view of the picture.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to