andymc12 commented on issue #619: CXF-8188: Inject into ClientHeadersFactory URL: https://github.com/apache/cxf/pull/619#issuecomment-573916489 @reta > CDIUtils and CDIFacade: we already use reflection-base BeanManager detection in CDIInterceptorWrapper::createWrapper, it think we should stick to one way to do it Agreed. I updated the CDIInterceptorWrapper to use CDIFacade/CDIUtils. > may be MicroProfileClientFactoryBean is a better place for dealing with CDI & ClientHeadersFactory, which could be passed to MicroProfileClientProxyImpl in a similar way as CDIInterceptorWrapper. The BeanManager detection logic (whichever we pick), could be reused for both of them. My latest changes reuse the BeanManager detection logic. I'm not sure if moving the ClientHeadersFactory logic into MicroProfileClientFactoryBean will work since that is when the client proxy is being created. It's possible the the rest client instance is created in one JAX-RS context (or outside of a JAX-RS request entirely) and then used in a different JAX-RS context. So then the injection would need to occur on each request, right? Thanks again!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
