dufoli commented on pull request #721: URL: https://github.com/apache/cxf/pull/721#issuecomment-727576192
1) what is the purpose of changing visitMaxs stuff ? and the reflection with visitMaxs ? To be honest, I do not know anything on that? Maybe it can be handled in another patch ? 2) Removing hashmap : it mean that you can not share same class path on 2 different invoker class or classloader. Currently if you have interface and implementor, it is not shared. Are you ok with this behaviour ? The second point is that if you have 2 methods on 2 sei with same name it will try to use the same class whereas today, it is separated ? are you sure it is ok ? I am just thinking to corner case ;-) 3) What is the gain of using bus.getExtension(TypeHelperClassLoader.class); and bus.getExtension(ClassLoader.class);. It use reflection for a class which can be directly called. Reflection is slower than direct call. Maybe I missed something, but not see the purpose to overload classLoader here ? Reflection have a cost and performance for interface call is important so if we can avoid it, maybe it is better no ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
