rmannibucau commented on pull request #721: URL: https://github.com/apache/cxf/pull/721#issuecomment-727577291
@dufoli 1. cause the parameters are not used anyway and I started to investigate if it was not the source of the stack error. Sure it can be in another patch (just started as a debug thing and I thought sharing it can be interesting) 2. this is not true since you go through the bus, you share all you want as you can see in my patch, it does exactly the same (+ it respects cxf bus classloader when configured ;)). These static maps are really not needed and shouldn't be there IMHO. Will avoid all java > 8 GC issues - the one you mentionned can happen with aggressive GC even if it was not the cause there. 3. gain of `bus.getExtension(ClassLoader.class)` is to respect cxf config, gain of `bus.getExtension(TypeHelperClassLoader.class)` is to drop the static unmanaged maps (which are leaks btw since not destroyed as soon as you destroy the server ;)). This can lead to issue in tests or redeployments/restart context if not done. I'm fine dropping any reflection cost for these particular types if you want. You can add these types in org.apache.cxf.bus.extension.ExtensionManagerBus#missingExtensions for ex. 4. about asm: we must keep ow2, spring and xbean [6-9] I'd say but it is also the part I mentionned at the beginning: once your asmhelper is in place, we can have one impl per asm version and therefore drop the generic asmhelper slowly once we have cxf-asmX module (for migration purposes). I suspect xbean will take the cxf integration once this change is released. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
