reta commented on a change in pull request #726:
URL: https://github.com/apache/cxf/pull/726#discussion_r524817976
##########
File path:
rt/features/metrics/src/main/java/org/apache/cxf/metrics/micrometer/provider/jaxws/JaxwsFaultCodeProvider.java
##########
@@ -26,20 +26,17 @@
public String getFaultCode(Exchange ex, boolean client) {
FaultMode fm = ex.get(FaultMode.class);
+ // We check OutFaultMessage/InFaultMessage only because some features
propagate the
+ // fault mode using InMessage/OutMessage (which may not end-up with a
fault), for
+ // example check MAPAggregatorImpl.
if (client) {
if (fm == null && ex.getInFaultMessage() != null) {
fm = ex.getInFaultMessage().get(FaultMode.class);
}
- if (fm == null && ex.getOutMessage() != null) {
- fm = ex.getOutMessage().get(FaultMode.class);
- }
} else {
if (fm == null && ex.getOutFaultMessage() != null) {
fm = ex.getOutFaultMessage().get(FaultMode.class);
}
- if (fm == null && ex.getInMessage() != null) {
Review comment:
@shark300 sorry for pinging, I've removed In Message (and Out Message)
from the fault code resolution. It seems like it is used by some features and
interceptors, however the fault logic only relies on In Fault / Out Fault.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
