reta commented on a change in pull request #726:
URL: https://github.com/apache/cxf/pull/726#discussion_r525620400
##########
File path:
rt/features/metrics/src/main/java/org/apache/cxf/metrics/micrometer/provider/jaxws/JaxwsFaultCodeProvider.java
##########
@@ -26,20 +26,17 @@
public String getFaultCode(Exchange ex, boolean client) {
FaultMode fm = ex.get(FaultMode.class);
+ // We check OutFaultMessage/InFaultMessage only because some features
propagate the
+ // fault mode using InMessage/OutMessage (which may not end-up with a
fault), for
+ // example check MAPAggregatorImpl.
if (client) {
if (fm == null && ex.getInFaultMessage() != null) {
fm = ex.getInFaultMessage().get(FaultMode.class);
}
- if (fm == null && ex.getOutMessage() != null) {
- fm = ex.getOutMessage().get(FaultMode.class);
- }
} else {
if (fm == null && ex.getOutFaultMessage() != null) {
fm = ex.getOutFaultMessage().get(FaultMode.class);
}
- if (fm == null && ex.getInMessage() != null) {
Review comment:
Thanks @shark300 , if for any reasons the response code is not set, we
reuse what logic from `AbstractHttpDestination`
(https://github.com/apache/cxf/pull/726/files#diff-d9de014df7f37e23ad17d9091884dd0edcd9203b26d6f1a4c8d55b9f802ab957R216),
in the nutshell it is `200` or `202` (partial response), not ideal but at
least consistent.
I don't have an integration test for this particular case (it is difficult
to verify that indeed response code was not set on server side, since client
will always get it), but I have unit tests for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
