shark300 commented on a change in pull request #726:
URL: https://github.com/apache/cxf/pull/726#discussion_r524975642
##########
File path:
rt/features/metrics/src/main/java/org/apache/cxf/metrics/micrometer/provider/jaxws/JaxwsFaultCodeProvider.java
##########
@@ -26,20 +26,17 @@
public String getFaultCode(Exchange ex, boolean client) {
FaultMode fm = ex.get(FaultMode.class);
+ // We check OutFaultMessage/InFaultMessage only because some features
propagate the
+ // fault mode using InMessage/OutMessage (which may not end-up with a
fault), for
+ // example check MAPAggregatorImpl.
if (client) {
if (fm == null && ex.getInFaultMessage() != null) {
fm = ex.getInFaultMessage().get(FaultMode.class);
}
- if (fm == null && ex.getOutMessage() != null) {
- fm = ex.getOutMessage().get(FaultMode.class);
- }
} else {
if (fm == null && ex.getOutFaultMessage() != null) {
fm = ex.getOutFaultMessage().get(FaultMode.class);
}
- if (fm == null && ex.getInMessage() != null) {
Review comment:
No problem, thank you for that :)
"Adjust the StandardTags.status() method to treat null values as 200" Is it
true in this case? I mean what is the HTTP status code in this case? As I see,
the logic should be similar to this one:
https://github.com/spring-projects/spring-boot/blob/master/spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/metrics/http/Outcome.java
Could you add a new integration test for this case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
