ffang commented on code in PR #3673:
URL: https://github.com/apache/cxf/pull/3673#discussion_r4472277113
##########
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpClientHTTPConduit.java:
##########
@@ -258,6 +257,84 @@ public HttpClientHTTPConduit(Bus b, EndpointInfo ei,
EndpointReferenceType t) th
super(b, ei, t);
}
+ private static boolean samePolicy(HTTPClientPolicy p1, HTTPClientPolicy
p2) {
+ // the version and the non proxy hosts are used to build the client too
+ return POLICY_CALCULATOR.equals(p1, p2)
Review Comment:
Hi @reta ,
With Colm's comment the client is now matched only on the settings it is
built from (connection timeout, proxy, non-proxy hosts, version), so
`ClientPolicyCalculator.equals` isn't used here anymore. That comparison is
specific to how the conduit builds its `HttpClient`, so I kept it in the
conduit rather than changing `ClientPolicyCalculator.equals`, which is also
used to compare WS-Policy assertions.
Freeman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
