ffang commented on code in PR #3673:
URL: https://github.com/apache/cxf/pull/3673#discussion_r4472284582
##########
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpClientHTTPConduit.java:
##########
@@ -258,6 +257,84 @@ public HttpClientHTTPConduit(Bus b, EndpointInfo ei,
EndpointReferenceType t) th
super(b, ei, t);
}
+ private static boolean samePolicy(HTTPClientPolicy p1, HTTPClientPolicy
p2) {
+ // the version and the non proxy hosts are used to build the client too
+ return POLICY_CALCULATOR.equals(p1, p2)
+ && Objects.equals(p1.getVersion(), p2.getVersion())
+ && Objects.equals(p1.getNonProxyHosts(), p2.getNonProxyHosts());
+ }
+
+ private static boolean sameClientParameters(TLSClientParameters p1,
TLSClientParameters p2) {
+ // the named groups are used to build the client too
+ return p1.equals(p2) && Objects.equals(p1.getNamedGroups(),
p2.getNamedGroups());
Review Comment:
Done, `TLSClientParameters.equals`/`hashCode` now include the named groups
(and the hostname verifier, which the client's trust managers are built with
too).
Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
