reta commented on code in PR #3673:
URL: https://github.com/apache/cxf/pull/3673#discussion_r4487065322
##########
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpClientHTTPConduit.java:
##########
@@ -411,7 +521,11 @@ protected void setupConnection(Message message, Address
address, HTTPClientPolic
RefCount<HttpClient> cl = clientRef;
if (cl == null) {
int ctimeout = determineConnectionTimeout(message, csPolicy);
- ProxySelector ps = new ProxyFactoryProxySelector(proxyFactory,
csPolicy);
+ // the client keeps copies of the settings it is built from, so
that it is not
+ // affected by later changes to the settings of this, or any
other, conduit
+ final HTTPClientPolicy clientPolicy = copyOf(csPolicy);
Review Comment:
Could we please move `copyOf` methods to HTTPClientPolicy /
TLSClientParameters ?
```
final HTTPClientPolicy clientPolicy = csPolicy.copy();
final TLSClientParameters clientParametersCopy = clientParameters.copy();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
