Github user mbeckerle commented on a diff in the pull request:
https://github.com/apache/incubator-daffodil/pull/12#discussion_r153948479
--- Diff:
daffodil-core/src/main/scala/edu/illinois/ncsa/daffodil/grammar/ByteOrderMixin.scala
---
@@ -71,17 +69,17 @@ trait ByteOrderAnalysisMixin extends GrammarMixin {
self: Term =>
}
-trait ByteOrderMixin extends ByteOrderAnalysisMixin { self: ElementBase =>
-
- protected final lazy val byteOrderChange =
- prod("byteOrderChange",
- enclosingTerm.isEmpty || (
- (thereIsAByteOrderDefined &&
- !isKnownSameByteOrder) || // need to change on the way in
- (isArray && !hasUniformByteOrderThroughout))) { // need to
change because of repetition
- // (when we start next iteration, it's not the same as when we
started first iteration)
- // THis will SDE if there is no byte order defined for the array
element (might only be byteOrder on things within the array)
- // So we're artificially requiring byte order on all arrays that
do not have a uniform byte order.
- ByteOrderChange(this)
- }
-}
+//trait ByteOrderMixin extends ByteOrderAnalysisMixin { self: ElementBase
=>
--- End diff --
Check that methods of ByteOrderAnalysisMixin are used somewhere. Otherwise
that trait can also be commented out/deleted.
---
