Github user stevedlawrence commented on a diff in the pull request:
https://github.com/apache/incubator-daffodil/pull/12#discussion_r154094249
--- Diff:
daffodil-core/src/main/scala/edu/illinois/ncsa/daffodil/grammar/primitives/PrimitivesBinaryNumber.scala
---
@@ -49,13 +49,18 @@ import
edu.illinois.ncsa.daffodil.processors.unparsers.BinaryDoubleUnparser
import edu.illinois.ncsa.daffodil.processors.unparsers.BinaryFloatUnparser
class BinaryIntegerRuntimeLength(val e: ElementBase, signed: Boolean)
extends Terminal(e, true) {
+
+ e.byteOrderEv // insure defined
--- End diff --
Also, does it make sense to have this somewhere else in the grammar? Maybe
related to dfdl:representation when it is "binary"? Removes duplication and
makes it less easier to miss things.
---
