mbeckerle commented on a change in pull request #12: Revised daffodil-io module
to require passing in a FormatInfo object.
URL: https://github.com/apache/incubator-daffodil/pull/12#discussion_r158168239
##########
File path:
daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/processors/Suspension.scala
##########
@@ -58,6 +58,15 @@ import edu.illinois.ncsa.daffodil.io.BitOrderChangeException
trait Suspension
extends Serializable with Logging {
+ /**
+ * Specifies that this suspension does not write to the data output stream.
+ *
+ * Override in TargetLengthOperation,and in SuspendableExpression as they
+ * don't write to the DOS hence, if a DOS is created it can be setFinished
+ * immediately.
+ *
+ * TODO: Redundant with implementing maybeKnownLengthInBits as MaybeULong(0L)
Review comment:
Remove this redundancy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
