mbeckerle commented on a change in pull request #12: Revised daffodil-io module
to require passing in a FormatInfo object.
URL: https://github.com/apache/incubator-daffodil/pull/12#discussion_r158083311
##########
File path:
daffodil-io/src/main/scala/edu/illinois/ncsa/daffodil/io/DataStreamCommonImplMixin.scala
##########
@@ -57,25 +72,21 @@ trait DataStreamCommonState {
// aka a surrogate-pair.
//
var maybeTrailingSurrogateForUTF8: MaybeChar = MaybeChar.Nope
- // var priorEncoding: Charset = StandardCharsets.UTF_8
var priorBitPos: Long = 0L
def resetUTF8SurrogatePairCapture {
- // this.maybeTrailingSurrogateForUTF8 = MaybeChar.Nope
this.priorBitPos = -1
}
def assignFrom(other: DataStreamCommonState): Unit = {
- // this.binaryFloatRep = other.binaryFloatRep
- // this.bitOrder = other.bitOrder
- // this.maybeCharWidthInBits = other.maybeCharWidthInBits
- // this.encodingMandatoryAlignmentInBits =
other.encodingMandatoryAlignmentInBits
- // this.maybeUTF16Width = other.maybeUTF16Width
this.debugging = other.debugging
this.limits_ = other.limits_
- // this.maybeTrailingSurrogateForUTF8 =
other.maybeTrailingSurrogateForUTF8
- // this.priorEncoding = other.priorEncoding
this.priorBitPos = other.priorBitPos
+ if (this.maybePriorBitOrder_.isDefined &&
+ other.maybePriorBitOrder_.isDefined &&
+ (this.maybePriorBitOrder_.get ne other.maybePriorBitOrder_.get)) {
+ }
Review comment:
Hmmm. I will have to investgate what happened here by comparing to earlier
versions. I don't know that priorBitOrder needs to be assigned by assignFrom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
