mbeckerle commented on a change in pull request #12: Revised daffodil-io module 
to require passing in a FormatInfo object.
URL: https://github.com/apache/incubator-daffodil/pull/12#discussion_r158082568
 
 

 ##########
 File path: 
daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/processors/Runtime.scala
 ##########
 @@ -241,6 +241,7 @@ class DataProcessor(val ssrd: SchemaSetRuntimeData)
       this.startElement(state, p)
       p.parse1(state)
       this.endElement(state, p)
+      state.setMaybeProcessor(Maybe(p)) // insures we can get context/ERD later
 
 Review comment:
   This restores an invariant which is that we have a processor that can be 
used to get the context. I'd swear I put a comment in to that effect, to 
document this little subtlety, but I don't see it here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to