stevedlawrence commented on a change in pull request #70: Adding property
binaryCalendarRep with values "binarySeconds" and "bi…
URL: https://github.com/apache/incubator-daffodil/pull/70#discussion_r189957892
##########
File path:
daffodil-test-ibm1/src/test/resources/test-suite/ibm-contributed/dpacalbin100_01.dfdl.xsd
##########
@@ -52,7 +53,8 @@
<xs:element name="testBinaryMilliseconds" type="xs:dateTime">
<xs:annotation>
<xs:appinfo source="http://www.ogf.org/dfdl/";>
- <dfdl:element
binaryCalendarRep="binaryMilliseconds"
binaryCalendarEpoch="2009-12-24T05:15:00+05:00"/>
+ <dfdl:element
binaryCalendarRep="binaryMilliseconds"
binaryCalendarEpoch="2009-12-24T05:15:00+05:00"
+ calendarPatternKind="explicit"
calendarPattern="yyyy-MM-dd'T'HH:mm:ssZZZZ" />
Review comment:
I wouldn't think calendarPatternKind and calendarPattern would be needed for
binaryCalendarRep. Those are really only for text parsing. Surprised they
aren't textCalendarPatternKind and textCalendarPattern. Maybe i'm not fully
understanding how binary calendar pattern works...It seems a lot of the
properties that are marked as for text or binary don't really apply to binary.
For example, calendarCheckPolicy, calendarFirstDayOfWeek,
calendarsDaysInFirstWeek, calendarCenturyStart, and calendarLanguage. Only ones
that maybe apply are calendarTimezone and calendarObserveDST since I think that
can affect how the infoset value is output. But maybe since they share the same
CalendarEv, it is actually required?
Might be a good idea to have some tests with some of these other properties
and see how the resulting infoset value is affected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
