stevedlawrence commented on a change in pull request #70: Adding property
binaryCalendarRep with values "binarySeconds" and "bi…
URL: https://github.com/apache/incubator-daffodil/pull/70#discussion_r189967091
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/ElementBaseGrammarMixin.scala
##########
@@ -775,6 +782,25 @@ trait ElementBaseGrammarMixin
}
case PrimType.Boolean => { new BinaryBoolean(this) }
+
+ case PrimType.DateTime | PrimType.Date | PrimType.Time => {
+ (primType, binaryCalendarRep) match {
+ case (PrimType.DateTime, BinaryCalendarRep.BinarySeconds) =>
(lengthUnits, binaryNumberKnownLengthInBits) match {
+ case (LengthUnits.Bytes, 32) => new
ConvertBinaryDateTimePrim(this, binaryNumberKnownLengthInBits)
Review comment:
I see. The spec also mentions this restriction for floating point numbers,
but I'm not sure we implement that. Seems like an odd restriction to me, as
long as the length is exactly 4 or 8 bytes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
