stevedlawrence commented on a change in pull request #70: Adding property
binaryCalendarRep with values "binarySeconds" and "bi…
URL: https://github.com/apache/incubator-daffodil/pull/70#discussion_r189982506
##########
File path:
daffodil-test-ibm1/src/test/resources/test-suite/ibm-contributed/dpacalbin100_01.dfdl.xsd
##########
@@ -52,7 +53,8 @@
<xs:element name="testBinaryMilliseconds" type="xs:dateTime">
<xs:annotation>
<xs:appinfo source="http://www.ogf.org/dfdl/";>
- <dfdl:element
binaryCalendarRep="binaryMilliseconds"
binaryCalendarEpoch="2009-12-24T05:15:00+05:00"/>
+ <dfdl:element
binaryCalendarRep="binaryMilliseconds"
binaryCalendarEpoch="2009-12-24T05:15:00+05:00"
+ calendarPatternKind="explicit"
calendarPattern="yyyy-MM-dd'T'HH:mm:ssZZZZ" />
Review comment:
Gotcha. Looks like we're just passing in too many arguments into the
BinaryCalendarParser then, likely because it is extending the
TextCalendarParser which does need those extra arguments. I *think* we just
need the calendarEv and maybe a couple others parameters. All the other stuff
should go away. And it even looks like some parameters are never used, even in
the TextCalendarParser. Might be good to clean some of that up while we're in
this code and splitting into a CalendarBaseParser (if needed).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
