stevedlawrence commented on a change in pull request #74: Daffodil trailing sep URL: https://github.com/apache/incubator-daffodil/pull/74#discussion_r195097304
########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/RuntimeData.scala ########## @@ -618,8 +622,9 @@ final class ElementRuntimeData( @TransientParam targetNamespaceArg: => NS, @TransientParam thisElementsNamespaceArg: => NS, @TransientParam optSimpleTypeRuntimeDataArg: => Option[SimpleTypeRuntimeData], - @TransientParam minOccursArg: => Option[Int], - @TransientParam maxOccursArg: => Option[Int], + @TransientParam minOccursArg: => Long, + @TransientParam maxOccursArg: => Long, Review comment: Can we actually support more more than IntMax array elements. I believe we still use an Array as the underlying data structure for storing arrays so I think these values are still limited to Int's. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
